WIP: Jupyterlab v3 to v4 dependencies update #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix pytest
fixing jest
adding jest-environment-jsdom because yes
adding @jupyterlab/testing
adding jest-junit
fixing path
fixing path
fixing path
fixing path
Changes to enable installing the extension
WIP: Update of jypyterlab v3 to jupytrelab v4 dependencies
Environment dependencies
garciagenrique
commented
May 10, 2024
pyproject.toml
Outdated
| @@ -29,7 +29,7 @@ dependencies = [ | |||
| "peewee", | |||
| "psutil", | |||
| "pyjwt", | |||
| "jsonschema", | |||
| "jsonschema<4.20", | |||
There was a problem hiding this comment.
@garciagenrique This restriction makes it incompatible with rucio_clients==34 that requires: jsonschema ~=4.20.0 . Is this intended?
There was a problem hiding this comment.
I think this was some leftovers from the tests with the different jsonschema versions. I would suggest to relax all the dependencies as much as possible and let the different developers/package managers install the needed dep versions for each rucio-jupyterlab version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jupyterlab v3 to v4 dependencies update.
This update compiles with
jupyterlab=4.1,python=3.11,notebook<7, andNodeJS=~20TODO before merging:
v0.10.0from current master branchCo-authored-by: Giovanni Guerrieri giovanni.guerrieri@cern.ch
Co-authored-by: Francesc Torradeflot torradeflot@pic.es