Skip to content

Commit

Permalink
Transfers: don't use last_processed_by logic in poller
Browse files Browse the repository at this point in the history
It already has a logic to avoid re-handling the same transfers again
by touching them and only retrieving transfers older than a duration.

Moreover, this logic doesn't play very well with receiver potentially
working on the same requests in parallel, because the poller tries
to update `last_processed_by` while receiver works on the same request,
resulting in deadlocks.
  • Loading branch information
rcarpa authored and bari12 committed Aug 3, 2023
1 parent ee14ee4 commit 33f9578
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion lib/rucio/daemons/conveyor/poller.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ def _fetch_requests(
transfs = request_core.get_and_mark_next(
request_type=[RequestType.TRANSFER, RequestType.STAGEIN, RequestType.STAGEOUT],
state=[RequestState.SUBMITTED],
processed_by=heartbeat_handler.short_executable,
limit=db_bulk,
older_than=datetime.datetime.utcnow() - datetime.timedelta(seconds=older_than) if older_than else None,
total_workers=total_workers,
Expand Down

0 comments on commit 33f9578

Please sign in to comment.