Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check that alembic version of DB works with rucio release #1157

Closed
briedel opened this issue May 14, 2018 · 3 comments · Fixed by #3947
Closed

Add check that alembic version of DB works with rucio release #1157

briedel opened this issue May 14, 2018 · 3 comments · Fixed by #3947
Assignees
@bziemons
Labels
Core & Internals feature
Milestone
1.24.0

Comments

@briedel
Copy link

briedel commented May 14, 2018

Motivation

  • Avoid errors when alembic_version is not set in the DB
  • Make sure that the server code can understand the DB schema.

Modification

At start up the RESTful API checks whether the alembic_version is in a whitelist, or whether the code version is supported.
@bari12
Copy link
Member

bari12 commented May 22, 2018

Hmm, it's technically not mandatory to use alembic to install the database, so looking for the alembic_version might not be the right approach. What we could do is to test if it is there and compare then, I am not so sure if this is really helpful though.

@briedel
Copy link
Author

briedel commented May 30, 2018 via email

@bari12
Copy link
Member

bari12 commented May 31, 2018

We discussed this in the meeting today. We will add a check for this in all daemons on startup.

  • If the alembic table is present, check if the right schema version is installed, if not fail.
  • If the alembic table is not present, do nothing for the moment. (This line we will remove eventually)

@bari12 bari12 added this to the 1.17.0 "Donkey Surfer" milestone May 31, 2018
@bari12 bari12 modified the milestones: 1.17.0, 1.17.1, 1.17.2 Jun 19, 2018
@bari12 bari12 modified the milestones: 1.17.2, 1.17.3 Jul 9, 2018
@bari12 bari12 modified the milestones: 1.17.5, 1.17.6 Jul 23, 2018
@bari12 bari12 modified the milestones: 1.17.6, 1.17.7 Aug 6, 2018
@bari12 bari12 modified the milestones: 1.17.7, 1.17.8 Aug 20, 2018
@bari12 bari12 modified the milestones: 1.18.0, 1.18.1 Sep 17, 2018
@bari12 bari12 modified the milestones: 1.18.1, 1.18.2 Oct 1, 2018
@bari12 bari12 modified the milestones: 1.18.3, 1.18.4 Oct 15, 2018
@bari12 bari12 removed this from the 1.18.4 milestone Oct 26, 2018
@bari12 bari12 added this to the 1.22.7 milestone May 18, 2020
@bari12 bari12 modified the milestones: 1.22.7, 1.22.8 Jun 2, 2020
@bari12 bari12 modified the milestones: 1.22.8, 1.22.X Jun 16, 2020
@bari12 bari12 modified the milestones: 1.22.X, 1.23.1 Jul 1, 2020
@bari12 bari12 modified the milestones: 1.23.1, 1.23.2 Jul 20, 2020
@bari12 bari12 modified the milestones: 1.23.2, 1.23.3 Aug 4, 2020
@bari12 bari12 assigned bziemons and unassigned vingar, mlassnig and bari12 Aug 7, 2020
bziemons added a commit to bziemons/rucio that referenced this issue Aug 19, 2020
@bziemons
Core & Internals: Implement first tests for failing on old DB; rucio#…
fc9ebe7 
…1157
bziemons added a commit to bziemons/rucio that referenced this issue Aug 19, 2020
@bziemons
Core & Internals: Add is_old_db method; Fix rucio#1157
6f0b482 
… to test for an old alembic revision in the database.
Implement first tests for failing on old DB.
Add alembic daemon startup test for old DB.
bziemons added a commit to bziemons/rucio that referenced this issue Aug 19, 2020
@bziemons
Core & Internals: Add is_old_db method; Fix rucio#1157
4f084f5 
… to test for an old alembic revision in the database.
Add is_old_db test in run_tests_docker.sh.
Add startup tests for old DB in all daemons.
Add test_daemons.py for testing all daemons on that behavior.
bziemons added a commit to bziemons/rucio that referenced this issue Aug 19, 2020
@bziemons
Core & Internals: Add is_old_db method; Fix rucio#1157
51ebd71 
… to test for an old alembic revision in the database.
Move alembic migration to tools/alembic_migration.sh.
Add is_old_db test in alembic_migration.sh.
Add startup tests for old DB in all daemons.
Add test_daemons.py for testing all daemons on that behavior.
bziemons added a commit to bziemons/rucio that referenced this issue Aug 21, 2020
@bziemons
Core & Internals: Add is_old_db method; Fix rucio#1157
4579d50 
… to test for an old alembic revision in the database.
Move alembic migration to tools/alembic_migration.sh.
Add is_old_db test in alembic_migration.sh.
Add startup tests for old DB in all daemons.
Add test_daemons.py for testing all daemons on that behavior.
@bziemons bziemons linked a pull request Aug 21, 2020 that will close this issue
Core & Internals: Add is_old_db method; Fix #1157 #3947
Merged
bziemons added a commit to bziemons/rucio that referenced this issue Aug 22, 2020
@bziemons
Core & Internals: Add is_old_db method; Fix rucio#1157
4988bbd 
… to test for an old alembic revision in the database.
Move alembic migration to tools/alembic_migration.sh.
Add is_old_db test in alembic_migration.sh.
Add startup tests for old DB in all daemons.
Add test_daemons.py for testing all daemons on that behavior.
bziemons added a commit to bziemons/rucio that referenced this issue Aug 28, 2020
@bziemons
Core & Internals: Add is_old_db method; Fix rucio#1157
7e386f5 
… to test for an old alembic revision in the database.
Move alembic migration to tools/alembic_migration.sh.
Add is_old_db test in alembic_migration.sh.
Add startup tests for old DB in all daemons.
Add test_daemons.py for testing all daemons on that behavior.
bziemons added a commit to bziemons/rucio that referenced this issue Sep 2, 2020
@bziemons
Core & Internals: Add is_old_db method; Fix rucio#1157
b8b293b 
… to test for an old alembic revision in the database.
Move alembic migration to tools/alembic_migration.sh.
Add is_old_db test in alembic_migration.sh.
Add startup tests for old DB in all daemons.
Add test_daemons.py for testing all daemons on that behavior.
bziemons added a commit to bziemons/rucio that referenced this issue Sep 14, 2020
@bziemons
Core & Internals: Add is_old_db method; Fix rucio#1157
b78529f 
… to test for an old alembic revision in the database.
Move alembic migration to tools/alembic_migration.sh.
Add is_old_db test in alembic_migration.sh.
Add startup tests for old DB in all daemons.
Add test_daemons.py for testing all daemons on that behavior.
bziemons added a commit to bziemons/rucio that referenced this issue Sep 22, 2020
@bziemons
Core & Internals: Add is_old_db method; Fix rucio#1157
21d337a 
… to test for an old alembic revision in the database.
Move alembic migration to tools/alembic_migration.sh.
Add is_old_db test in alembic_migration.sh.
Add startup tests for old DB in all daemons.
Add test_daemons.py for testing all daemons on that behavior.
bari12 added a commit that referenced this issue Sep 25, 2020
@bari12
Merge pull request #3947 from bziemons/feature-1157-check_alembic_rev…
5419714 
…ision_in_daemons

Core & Internals: Add is_old_db method; Fix #1157
@bari12 bari12 added this to the 1.24.0 "Aquadonkey" milestone Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bziemons bziemons

Labels
Core & Internals feature
Projects
None yet
Milestone
1.24.0
Development

Successfully merging a pull request may close this issue.

Core & Internals: Add is_old_db method; Fix #1157 bziemons/rucio
5 participants
@mlassnig @bari12 @bziemons @briedel @vingar