Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing default value for filter options in downloadclient #2249

Closed
hahahannes opened this issue Feb 21, 2019 · 0 comments
Closed

missing default value for filter options in downloadclient #2249

hahahannes opened this issue Feb 21, 2019 · 0 comments
Assignees
@hahahannes
Labels
bug Clients
Milestone
1.19.3-clients

Comments

@hahahannes
Copy link
Contributor

Motivation

There should be a default value if no filter option is passed to the downloadclient.

Modification

Change https://github.com/rucio/rucio/blob/master/lib/rucio/client/downloadclient.py#L1071 to item.get('filters', {})
@hahahannes hahahannes self-assigned this Feb 21, 2019
hahahannes added a commit to hahahannes/rucio that referenced this issue Feb 25, 2019
@hahahannes
Clients: added missing default value for filter options and tests for…
636ec1a 
… downloadclient; Fix rucio#2249
This was referenced Feb 25, 2019
Merged
Merged
hahahannes added a commit to hahahannes/rucio that referenced this issue Feb 25, 2019
@hahahannes
Clients: added missing default value for filter options and tests for…
44705b8 
… downloadclient; Fix rucio#2249
hahahannes added a commit to hahahannes/rucio that referenced this issue Feb 25, 2019
@hahahannes
Clients: added missing default value for filter options and tests for…
f1dee29 
… downloadclient; Fix rucio#2249
bari12 added a commit that referenced this issue Feb 25, 2019
@bari12
Merge pull request #2256 from hahahannes/patch-2249-missing_filter_de…
0b34af6 
…fault_value

Clients: added missing default value for filter options and tests for downloadclient; Fix #2249
bari12 added a commit that referenced this issue Feb 25, 2019
@bari12
Merge pull request #2255 from hahahannes/patch-2249-missing_filter_de…
10e0315 
…fault_value

Clients: added missing default value for filter options and tests for downloadclient; Fix #2249
@bari12 bari12 added this to the 1.19.3-clients milestone Feb 25, 2019
Ruturaj123 pushed a commit to Ruturaj123/rucio that referenced this issue Jun 19, 2019
@hahahannes @Ruturaj123
Clients: added missing default value for filter options and tests for…
4384f5a 
… downloadclient; Fix rucio#2249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hahahannes hahahannes

Labels
bug Clients
Projects
None yet
Milestone
1.19.3-clients
Development

No branches or pull requests
2 participants
@bari12 @hahahannes