Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STOMP connections are not always cleanly closed #2606

Closed
LionelCons opened this issue May 27, 2019 · 2 comments · Fixed by #4895
Closed

STOMP connections are not always cleanly closed #2606

LionelCons opened this issue May 27, 2019 · 2 comments · Fixed by #4895
Assignees
@mlassnig @tbeerman
Labels
bug Messaging Traces
Milestone
1.26.6

Comments

@LionelCons
Copy link

The STOMP specification (https://stomp.github.io/stomp-specification-1.2.html#DISCONNECT) indicates that connections should be closed using the DISCONNECT frame and a receipt.

It seems that there are 4 places where STOMP connections are created but not closed explicitly using stomp.py's disconnect(): lib/rucio/core/trace.py, lib/rucio/core/nongrid_trace.py and lib/rucio/daemons/hermes/hermes.py.

FWIW, disconnect() is used elsewhere: bin/rucio-cache-client, lib/rucio/daemons/cache/consumer.py, lib/rucio/daemons/conveyor/receiver.py and lib/rucio/daemons/tracer/kronos.py.
@bari12
Copy link
Member

bari12 commented May 27, 2019

Hi Lionel,
Thanks for reporting; We will have a look!

This was referenced Jul 5, 2019
Merged
Merged
tbeerman added a commit to tbeerman/rucio that referenced this issue Jul 5, 2019
@tbeerman
Hermes: cleanly close STOMP connections rucio#2606
0052b6e
bari12 added a commit that referenced this issue Jul 5, 2019
@bari12
Merge pull request #2718 from tbeerman/patch-2606-add_disconnect_to_h…
342e083 
…ermes

Hermes: cleanly close STOMP connections #2606
bari12 added a commit that referenced this issue Jul 5, 2019
@bari12
Merge pull request #2719 from tbeerman/patch-2606-add_disconnect_to_h…
b3abd59 
…ermes

Hermes: cleanly close STOMP connections #2606
@ericvaandering
Copy link
Contributor

Reopening this issue

@ericvaandering ericvaandering reopened this Oct 6, 2021
@ericvaandering ericvaandering mentioned this issue Oct 6, 2021
Merged
@ericvaandering ericvaandering linked a pull request Oct 6, 2021 that will close this issue
Messaging: Stop SSL reconnects #4895
Merged
@bari12 bari12 added this to the 1.26.6 milestone Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlassnig mlassnig

@tbeerman tbeerman

Labels
bug Messaging Traces
Projects
None yet
Milestone
1.26.6
Development

Successfully merging a pull request may close this issue.

Messaging: Stop SSL reconnects ericvaandering/rucio
5 participants
@mlassnig @LionelCons @tbeerman @bari12 @ericvaandering