Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscription client does not allow listing subscriptions by name only #3582

Closed
elichad opened this issue May 12, 2020 · 0 comments
Closed

Subscription client does not allow listing subscriptions by name only #3582

elichad opened this issue May 12, 2020 · 0 comments
Assignees
@elichad
Labels
enhancement Subscriptions
Milestone
1.22.7

Comments

@elichad
Copy link
Contributor

elichad commented May 12, 2020

Motivation

SubscriptionClient.list_subscriptions takes both account and name as arguments, but the name is only added to the path if an account is specified. API/core functions already work with a name only, so it's just a matter of updating the client.

Modification

Adapt SubscriptionClient.list_subscriptions to add the name to the path even when the account is not specified.
@elichad elichad self-assigned this May 12, 2020
@bari12 bari12 closed this as completed in 5dcca66 May 28, 2020
bari12 added a commit that referenced this issue May 28, 2020
@bari12
Merge pull request #3596 from stfc/patch-3582-client_subscriptions_by…
f27f723 
…_name

Subscriptions: Add client retrieval of subscriptions by name; Fix #3582
@bari12 bari12 added this to the 1.22.7 milestone May 28, 2020
bari12 added a commit that referenced this issue May 28, 2020
@bari12
Merge pull request #3597 from stfc/patch-3582-client_subscriptions_by…
ce295c3 
…_name

Subscriptions: Add client retrieval of subscriptions by name; Fix #3582
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elichad elichad

Labels
enhancement Subscriptions
Projects
None yet
Milestone
1.22.7
Development

No branches or pull requests
2 participants
@bari12 @elichad