New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot update the account of a rule #3794
Comments
Update rule uses a dictionary of options which can contain an account, but we missed this when implementing InternalAccount types as it didn't appear as an argument to the API function directly. Have submitted a PR which fixes this, but I also want to check we haven't missed anywhere else doing a similar thing, and possibly add a test that explicitly tests this (currently |
Found a couple of places where an account could be included in a dictionary representing a DID, and passed through the API layer without conversion to InternalAccount. Normally this account is simply not included and the issuer is used instead at the core without issue. However if an account was provided it would cause a similar error to this, so I added checks to make sure any optional accounts are now converted. |
…ptions_to_internal bug, Core & Internals: Convert update rule options to internal #3794
Motivation
Modification
The text was updated successfully, but these errors were encountered: