Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rucio update-rule --cancel-requests should using either --stuck or --suspend #3838

Closed
dchristidis opened this issue Jul 10, 2020 · 0 comments · Fixed by #4887
Closed

rucio update-rule --cancel-requests should using either --stuck or --suspend #3838

dchristidis opened this issue Jul 10, 2020 · 0 comments · Fixed by #4887
Assignees
@joeldierkes
Labels
Clients enhancement Rules
Milestone
1.26.6-clients

Comments

@dchristidis
Copy link
Contributor

Motivation

Running rucio update-rule --cancel-requests RULE has no effect, yet the client terminates successfully.

Modification

Show an error message, explaining that either --stuck or --suspend must also be used.
@bari12 bari12 self-assigned this Jul 20, 2020
@bari12 bari12 added the Rules label Jul 20, 2020
@bari12 bari12 assigned maany and unassigned bari12 Jun 10, 2021
@bari12 bari12 assigned joeldierkes and unassigned maany Oct 5, 2021
joeldierkes pushed a commit to joeldierkes/rucio that referenced this issue Oct 5, 2021
Clients: enforce rucio update-rule --cancel-requests to specify a state
98c8937 
rucio#3838

`rucio update-rule --cancel-reqeusts` needs a state to determine its
utilization. Right now the program exits normaly without any error if no state
is given, letting the user believe everything worked out.

This commit enforces the specification of a state, with `--stuck` or
`--suspend`. If no state is given, the program exits with an error.

The program would just exit normaly and
@joeldierkes joeldierkes linked a pull request Oct 5, 2021 that will close this issue
Clients: enforce rucio update-rule --cancel-requests to specify a state #3838 #4887
Merged
joeldierkes pushed a commit to joeldierkes/rucio that referenced this issue Oct 11, 2021
Clients: enforce rucio update-rule --cancel-requests to specify a state
3a8fd12 
rucio#3838

`rucio update-rule --cancel-reqeusts` needs a state to determine its
utilization. Right now the program exits normaly without any error if no state
is given, letting the user believe everything worked out.

This commit enforces the specification of a state, with `--stuck` or
`--suspend`. If no state is given, the program exits with an error.
bari12 added a commit that referenced this issue Oct 11, 2021
@bari12
Merge pull request #4887 from joeldierkes/feature-3838-rucio_update_r…
ba73b6f 
…ule___cancel_requests

Clients: enforce rucio update-rule --cancel-requests to specify a state #3838
bari12 pushed a commit that referenced this issue Oct 11, 2021
@bari12
Clients: enforce rucio update-rule --cancel-requests to specify a state
5dbde39 
#3838

`rucio update-rule --cancel-reqeusts` needs a state to determine its
utilization. Right now the program exits normaly without any error if no state
is given, letting the user believe everything worked out.

This commit enforces the specification of a state, with `--stuck` or
`--suspend`. If no state is given, the program exits with an error.
@bari12 bari12 added this to the 1.26.6-clients milestone Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeldierkes joeldierkes

Labels
Clients enhancement Rules
Projects
None yet
Milestone
1.26.6-clients
Development

Successfully merging a pull request may close this issue.

Clients: enforce rucio update-rule --cancel-requests to specify a state #3838 joeldierkes/rucio
4 participants
@bari12 @dchristidis @maany @joeldierkes