Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some daemons CLI are missing a sleep-time option #3987

Closed
cserf opened this issue Sep 9, 2020 · 1 comment · Fixed by #4722
Closed

Some daemons CLI are missing a sleep-time option #3987

cserf opened this issue Sep 9, 2020 · 1 comment · Fixed by #4722
Assignees
@davidpob99 @cserf
Labels
Core & Internals patch
Milestone
1.26.2

Comments

@cserf
Copy link
Contributor

cserf commented Sep 9, 2020

Motivation

Some daemons CLI are missing a sleep-time option. It needs to be added
@bari12 bari12 changed the title Daemons : Some daemons CLI are missing a sleep-time option Some daemons CLI are missing a sleep-time option Sep 9, 2020
@davidpob99
Copy link
Member

I've been working on this and I have some questions with some daemons:

  • c3po: it seems that waiting_time==sleep_time, but there is a value different for each function (read_free_space, read_workflow, ...). Should I add a command argument to change each one?
  • conveyor.fts_throttler: is cycle_interval==sleep_time? Should rename the variable to sleep_time?
  • conveyor.poller_latest: is fts-wait==sleep_time? Should rename the variable to sleep_time?
  • follower: cannot add sleep_time because of get_thread_with_periodic_running_function
  • hermes: is delay==sleep_time? Should rename the variable to sleep_time?
  • oauthmanager: is loop_rate==sleep_time? Should rename the variable to sleep_time?

davidpob99 added a commit to davidpob99/rucio that referenced this issue Jul 7, 2021
@davidpob99
Clients: add sleep-time option to daemons rucio#3987
55e27d2
@davidpob99 davidpob99 mentioned this issue Jul 7, 2021
Merged
davidpob99 added a commit to davidpob99/rucio that referenced this issue Aug 6, 2021
@davidpob99
Clients: add sleep-time option to daemons rucio#3987
ea90368
davidpob99 added a commit to davidpob99/rucio that referenced this issue Aug 13, 2021
@davidpob99
Clients: add sleep-time option to daemons rucio#3987
3cbdeba
bari12 pushed a commit that referenced this issue Aug 13, 2021
@davidpob99
Clients: add sleep-time option to daemons. Closes #3987 (#4722)
83943be 
* Clients: add sleep-time option to daemons #3987

* Fix syntax problems

* Avoid code repetition

* Fix syntax problems

* Add logger to daemon_sleep and change headers with script

* Update headers
bari12 pushed a commit that referenced this issue Aug 13, 2021
@davidpob99 @bari12
Clients: add sleep-time option to daemons. Closes #3987 (#4722)
91e13b1 
* Clients: add sleep-time option to daemons #3987

* Fix syntax problems

* Avoid code repetition

* Fix syntax problems

* Add logger to daemon_sleep and change headers with script

* Update headers
@bari12 bari12 added this to the 1.26.2 milestone Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidpob99 davidpob99

@cserf cserf

Labels
Core & Internals patch
Projects
None yet
Milestone
1.26.2
Development

Successfully merging a pull request may close this issue.

Clients: add sleep-time option to daemons. Closes #3987 davidpob99/rucio
3 participants
@bari12 @davidpob99 @cserf