Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark Reaper does not work with Python 3 #4256

Closed
dchristidis opened this issue Jan 20, 2021 · 0 comments · Fixed by #4257
Closed

Dark Reaper does not work with Python 3 #4256

dchristidis opened this issue Jan 20, 2021 · 0 comments · Fixed by #4257
Assignees
@dchristidis
Labels
bug Consistency checks
Milestone
1.24.2

Comments

@dchristidis
Copy link
Contributor

Motivation

Traceback (most recent call last):
  File "/usr/lib64/python3.6/threading.py", line 916, in _bootstrap_inner
    self.run()
  File "/usr/lib64/python3.6/threading.py", line 864, in run
    self._target(*self._args, **self._kwargs)
  File "/usr/local/lib/python3.6/site-packages/rucio/daemons/reaper/dark_reaper.py", line 84, in reaper
    hash_executable = hashlib.sha256(sys.argv[0] + ''.join(rses)).hexdigest()
TypeError: Unicode-objects must be encoded before hashing

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/site-packages/rucio/daemons/reaper/dark_reaper.py", line 114, in reaper
    operation='delete', scheme=scheme).values()[0])
TypeError: 'dict_values' object does not support indexing

Modification

Port to Python 3.
@dchristidis dchristidis self-assigned this Jan 20, 2021
dchristidis added a commit to dchristidis/rucio that referenced this issue Jan 20, 2021
@dchristidis
Consistency: Port Dark Reaper to Python 3 rucio#4256
03662c7
@dchristidis dchristidis mentioned this issue Jan 20, 2021
Merged
dchristidis added a commit to dchristidis/rucio that referenced this issue Jan 20, 2021
@dchristidis
Consistency: Port Dark Reaper to Python 3 rucio#4256
b93b636
bari12 added a commit that referenced this issue Jan 21, 2021
@bari12
Merge pull request #4257 from dchristidis/feature-4256-Consistency__P…
304ec0f 
…ort_Dark_Reaper_to_Python_3

Consistency: Port Dark Reaper to Python 3 #4256
bari12 pushed a commit that referenced this issue Jan 21, 2021
@dchristidis @bari12
Consistency: Port Dark Reaper to Python 3 #4256
0caf5d4
@bari12 bari12 added this to the 1.24.2 milestone Jan 21, 2021
maany pushed a commit to maany/rucio that referenced this issue Jan 21, 2021
@dchristidis @maany
Consistency: Port Dark Reaper to Python 3 rucio#4256
633b9f4
dchristidis added a commit to dchristidis/rucio that referenced this issue Jan 25, 2021
@dchristidis
Core: Fix ATLAS permission for declaring bad PFNs rucio#4256
d1bd6b0 
This is a stopgap solution. It should be followed up in issue rucio#4269.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dchristidis dchristidis

Labels
bug Consistency checks
Projects
None yet
Milestone
1.24.2
Development

Successfully merging a pull request may close this issue.

Consistency: Port Dark Reaper to Python 3 #4256 dchristidis/rucio
2 participants
@bari12 @dchristidis