Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark reaper mismatch between RSE ID and dictionary. #4285

Closed
ericvaandering opened this issue Feb 2, 2021 · 0 comments
Closed

Dark reaper mismatch between RSE ID and dictionary. #4285

ericvaandering opened this issue Feb 2, 2021 · 0 comments
Assignees
@ericvaandering
Labels
bug Consistency checks
Milestone
1.24.3

Comments

@ericvaandering
Copy link
Contributor

Motivation

I’m guessing ATLAS runs the dark reaper without any of the RSE parameters? 1.24.2 appears to be broken.

rucio/lib/rucio/daemons/reaper/dark_reaper.py

Line 242 in 2b2ab75

if exclude_rses:
The problem is that at this point rses is just a list of ID hashes for the RSE and the return from parse expression is full dictionary.

Modification

A line like
excluded_rses = [rse['id'] for rse in excluded_rses]
is needed.
@ericvaandering ericvaandering self-assigned this Feb 2, 2021
@ericvaandering ericvaandering mentioned this issue Feb 2, 2021
Merged
@bari12 bari12 closed this as completed in 002b7e4 Feb 4, 2021
bari12 pushed a commit that referenced this issue Feb 4, 2021
@ericvaandering @bari12
Deletion: Fix DarkReaper arguments Fix #4285 (#4286)
d1b4c0d 
* Dark reaper patch
* cleanup code
@bari12 bari12 added this to the 1.24.3 milestone Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericvaandering ericvaandering

Labels
bug Consistency checks
Projects
None yet
Milestone
1.24.3
Development

No branches or pull requests
2 participants
@bari12 @ericvaandering