Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configparser loads entire ENV space #4410

Closed
bari12 opened this issue Mar 12, 2021 · 0 comments
Closed

Configparser loads entire ENV space #4410

bari12 opened this issue Mar 12, 2021 · 0 comments
Assignees

Comments

@bari12
Copy link
Member

bari12 commented Mar 12, 2021

Motivation

For probably historic reasons our config parser (For rucio.cfg) also loads the entire ENV space into the config parser. This causes certain issues at a few sites, since the parser breaks do to their environment setup (Duplicate keys etc.)

if sys.version_info < (3, 2):
self.parser = ConfigParser.SafeConfigParser(os.environ)
else:
self.parser = ConfigParser.ConfigParser(defaults=os.environ)

I do not think that it is necessary to load the entire ENV space in there, since the ENV variables we are interested in, are usually directly accessed from the environment.

  1. Investigate if this is really needed
  2. If not take it out from the Configparser
rcarpa added a commit to rcarpa/rucio that referenced this issue Mar 22, 2021
rcarpa added a commit to rcarpa/rucio that referenced this issue Mar 22, 2021
bari12 added a commit that referenced this issue Mar 23, 2021
…ad_env

Clients: don't load env into config defaults. #4410
@bari12 bari12 modified the milestones: 1.25.2, 1.25.2-clients Mar 23, 2021
@bari12 bari12 closed this as completed Mar 23, 2021
dynamic-entropy pushed a commit to dynamic-entropy/rucio that referenced this issue Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants