Remove pytest tests from clients package

[kratsg]

$ python3 -m pip install rucio-clients -qqq
$ rucio whoami
Traceback (most recent call last):
  File "/usr/local/bin/rucio", line 75, in <module>
    from rucio.tests.test_rucio_server import TestRucioClient
  File "/usr/local/lib/python3.6/site-packages/rucio/tests/test_rucio_server.py", line 28, in <module>
    import pytest
ModuleNotFoundError: No module named 'pytest'

It seems to be that the latest release is forcing a call to test_rucio_server which is causing this error to occur. Can this be triaged quickly and probably get the latest release yanked from pypi?

• https://pypi.org/project/rucio-clients/1.25.1/

(Internal ATLAS reference to failed pipeline: https://gitlab.cern.ch/atlas-phys-susy-wg/Combinations/supersamples/-/jobs/12819064 )

[bari12]

Thanks Giordon for reporting this.
The issue is due to us switching to pytest for testing (And the test files are included in the client package) this issue comes up if you do not have pytest in your environment.
We have to see how we fix this, probably we will remove the test files from the client package entirely.

For ATLAS workflows though it is recommended to use the rucio versions used in the ATLAS Local Root Base, since these are confirmed to work with ATLAS workflows and are tested more intensively in this context.

I have yanked the release in the meanwhile.

[kratsg]

The issue is due to us switching to pytest for testing (And the test files are included in the client package) this issue comes up if you do not have pytest in your environment.

yes, of course, but I would expect that rucio would declare pytest as a dependency if so (but I don't usually see pytest as a required user dependency, only more a developer dependency and additionally not shipping any testing in the python package.

[bziemons]

The issue was not introduced when switching to pytest, but here:

rucio/lib/rucio/tests/test_rucio_server.py

Line 73 in 45afd73

@pytest.mark.noparallel(reason='uses pre-defined RSE')

in fcf1f05

It was just overlooked by me that this file is used in the clients. I have prepared a fix by moving the test code in #4483