Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLAlchemy changed the Enum create_constraint default #4737

Closed
bziemons opened this issue Jul 16, 2021 · 0 comments · Fixed by #4738
Closed

SQLAlchemy changed the Enum create_constraint default #4737

bziemons opened this issue Jul 16, 2021 · 0 comments · Fixed by #4738
Assignees
Milestone

Comments

@bziemons
Copy link
Member

bziemons commented Jul 16, 2021

Motivation

Since the SQLAlchemy update to 1.4 the model metadata does not create constraints for Enum columns anymore, see the create_constraints parameter: https://docs.sqlalchemy.org/en/14/core/type_basics.html#sqlalchemy.types.Enum.params.create_constraint

Edit: The same applies for Boolean types: https://docs.sqlalchemy.org/en/14/core/type_basics.html#sqlalchemy.types.Boolean.params.create_constraint

Modification

Modify all occurrences of the Enum type in the model and set create_constraints to True.

@bziemons bziemons self-assigned this Jul 16, 2021
bziemons added a commit to bziemons/rucio that referenced this issue Jul 16, 2021
@bziemons bziemons linked a pull request Jul 16, 2021 that will close this issue
bziemons added a commit to bziemons/rucio that referenced this issue Jul 16, 2021
Rename SUBS_HISTORY_RETROACTIVE_CHK (as in schema.sql for Oracle)
bari12 added a commit that referenced this issue Jul 16, 2021
…onstraint

Database: Add create_constraint parameter; Fix #4737
@bari12 bari12 added this to the 1.26.0 milestone Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants