Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database: fix deletion of old tokens #4815

Closed
davidpob99 opened this issue Sep 1, 2021 · 0 comments · Fixed by #4822
Closed

Database: fix deletion of old tokens #4815

davidpob99 opened this issue Sep 1, 2021 · 0 comments · Fixed by #4822
Assignees
@davidpob99
Labels
Authentication & Authorisation enhancement
Milestone
1.26.8

Comments

@davidpob99
Copy link
Member

Motivation

The current deletion of old tokens does not work properly (deadlocks) and the hints do not run:

rucio/lib/rucio/core/authentication.py

Lines 139 to 140 in 7c8f6ae

session.query(models.Token).filter(models.Token.expired_at < datetime.datetime.utcnow(),
models.Token.account == account).with_for_update(skip_locked=True).delete()

Modification

Rewrite the queries to the new SQLAlchemy syntax, splitting each of them in a select and a delete statement. Add the following hint in the delete statement:

rucio/lib/rucio/db/sqla/models.py

Line 120 in 7c8f6ae

element = element.prefix_with("/*+ INDEX(TOKENS_ACCOUNT_EXPIRED_AT_IDX) */")

@mlassnig mlassnig mentioned this issue Sep 2, 2021
Closed
davidpob99 added a commit to davidpob99/rucio that referenced this issue Sep 6, 2021
@davidpob99
Authentication: fix deletion of old tokens from DB rucio#4815
e37e502
@davidpob99 davidpob99 mentioned this issue Sep 6, 2021
Merged
davidpob99 added a commit to davidpob99/rucio that referenced this issue Sep 6, 2021
@davidpob99
Authentication: fix deletion of old tokens from DB rucio#4815
d61c76a
davidpob99 added a commit to davidpob99/rucio that referenced this issue Sep 6, 2021
@davidpob99
Authentication: fix deletion of old tokens from DB rucio#4815
fa6cd1a
bari12 pushed a commit that referenced this issue Oct 25, 2021
@davidpob99 @mlassnig
Authentication: fix deletion of old tokens from DB. Closes #4815 (#4822)
7ab878a 
* Authentication: fix deletion of old tokens from DB #4815

* Update authentication.py

Co-authored-by: Mario Lassnig <mlassnig@users.noreply.github.com>
bari12 pushed a commit that referenced this issue Oct 25, 2021
@davidpob99 @mlassnig @bari12
Authentication: fix deletion of old tokens from DB. Closes #4815 (#4822)
8b23511 
* Authentication: fix deletion of old tokens from DB #4815

* Update authentication.py

Co-authored-by: Mario Lassnig <mlassnig@users.noreply.github.com>
@bari12 bari12 added this to the 1.26.8 milestone Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidpob99 davidpob99

Labels
Authentication & Authorisation enhancement
Projects
None yet
Milestone
1.26.8
Development

Successfully merging a pull request may close this issue.

Authentication: fix deletion of old tokens from DB. Closes #4815 davidpob99/rucio
2 participants
@bari12 @davidpob99