Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve AD32 checksum calculation #4879

Closed
mlassnig opened this issue Oct 1, 2021 · 0 comments
Closed

Improve AD32 checksum calculation #4879

mlassnig opened this issue Oct 1, 2021 · 0 comments
Assignees
@mlassnig
Labels
Core & Internals enhancement
Milestone
1.26.8

Comments

@mlassnig
Copy link
Contributor

mlassnig commented Oct 1, 2021

Motivation

Right now the function relies on newlines. This is error-prone and can easily cause problems with binary files.

Modification

Memory map the file and do binary block calculation.
@mlassnig mlassnig self-assigned this Oct 1, 2021
mlassnig added a commit to mlassnig/rucio that referenced this issue Oct 1, 2021
@mlassnig
Improve AD32 checksum calculation; Fix rucio#4879
1bf2c72
@bari12 bari12 closed this as completed in 8c6552b Oct 25, 2021
bari12 pushed a commit that referenced this issue Oct 25, 2021
@mlassnig @bari12
Improve AD32 checksum calculation; Fix #4879 (#4880)
325af29 
* Improve AD32 checksum calculation; Fix #4879

* forgot import

* increase buffer size

* Remove buffer size increase
@bari12 bari12 added this to the 1.26.8 milestone Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mlassnig mlassnig

Labels
Core & Internals enhancement
Projects
None yet
Milestone
1.26.8
Development

No branches or pull requests
2 participants
@mlassnig @bari12