Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated Contributing guide #5176

Closed
joeldierkes opened this issue Jan 24, 2022 · 0 comments · Fixed by #5183
Closed

Duplicated Contributing guide #5176

joeldierkes opened this issue Jan 24, 2022 · 0 comments · Fixed by #5183
Assignees
@joeldierkes
Labels
bug Documentation enhancement
Milestone
1.27.4

Comments

@joeldierkes
Copy link
Contributor

joeldierkes commented Jan 24, 2022 •
edited

Motivation

The contributing guide exists in the documentation and rucio repository. This could lead to diverging versions of the contributing guide.

Modification

Unify the contribution guide either in documentation and link the rucio/CONTRIBUTING.rst to it or store it in in rucio.
@joeldierkes joeldierkes self-assigned this Jan 24, 2022
@joeldierkes joeldierkes mentioned this issue Jan 25, 2022
Merged
joeldierkes pushed a commit to joeldierkes/rucio that referenced this issue Jan 26, 2022
Documentation: Unify the contribution Guide rucio#5176
bf506f0 
The contribution guide is duplicated. It exists in `rucio/CONTRIBUTING.rst` and
in the `documentation` project. Over time, these files could diverge, which is
not desirable.

This commit makes the CONTRIBUTING file in `documentation` the main guide for
contributions and changes all references to it.
@joeldierkes joeldierkes linked a pull request Jan 26, 2022 that will close this issue
Documentation: Unify the contribution Guide #5176 #5183
Merged
joeldierkes pushed a commit to joeldierkes/rucio that referenced this issue Jan 27, 2022
Documentation: Unify the contribution Guide rucio#5176
ae29784 
The contribution guide is duplicated. It exists in `rucio/CONTRIBUTING.rst` and
in the `documentation` project. Over time, these files could diverge, which is
not desirable.

This commit makes the CONTRIBUTING file in `documentation` the main guide for
contributions and changes all references to it.
joeldierkes pushed a commit to joeldierkes/rucio that referenced this issue Jan 27, 2022
Documentation: Unify the contribution Guide rucio#5176
7684890 
The contribution guide is duplicated. It exists in `rucio/CONTRIBUTING.rst` and
in the `documentation` project. Over time, these files could diverge, which is
not desirable.

This commit makes the CONTRIBUTING file in `documentation` the main guide for
contributions and changes all references to it.
bari12 added a commit that referenced this issue Jan 31, 2022
@bari12
Merge pull request #5183 from joeldierkes/patch-5176-Duplicated_Contr…
7a3cbc8 
…ibuting_guide

Documentation: Unify the contribution Guide #5176
bari12 pushed a commit that referenced this issue Jan 31, 2022
@bari12
Documentation: Unify the contribution Guide #5176
7f5be6c 
The contribution guide is duplicated. It exists in `rucio/CONTRIBUTING.rst` and
in the `documentation` project. Over time, these files could diverge, which is
not desirable.

This commit makes the CONTRIBUTING file in `documentation` the main guide for
contributions and changes all references to it.
@bari12 bari12 added this to the 1.27.4 milestone Jan 31, 2022
piperov pushed a commit to piperov/rucio that referenced this issue Feb 25, 2022
@piperov
Documentation: Unify the contribution Guide rucio#5176
e573f5f 
The contribution guide is duplicated. It exists in `rucio/CONTRIBUTING.rst` and
in the `documentation` project. Over time, these files could diverge, which is
not desirable.

This commit makes the CONTRIBUTING file in `documentation` the main guide for
contributions and changes all references to it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeldierkes joeldierkes

Labels
bug Documentation enhancement
Projects
None yet
Milestone
1.27.4
Development

Successfully merging a pull request may close this issue.

Documentation: Unify the contribution Guide #5176 joeldierkes/rucio
2 participants
@bari12 @joeldierkes