Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement checksum comparison in suspicious replica recoverer #5334

Closed
ChristophAmes opened this issue Mar 8, 2022 · 0 comments
Closed

Implement checksum comparison in suspicious replica recoverer #5334

ChristophAmes opened this issue Mar 8, 2022 · 0 comments
Assignees
@ChristophAmes
Labels
feature Recovery
Milestone
1.28.5

Comments

@ChristophAmes
Copy link
Contributor

ChristophAmes commented Mar 8, 2022 •
edited

Before the suspicious replica recoverer marks a file as bad, it should first be confirmed that the replica is bad. To do this, a checksum comparison should be performed. Currently, the reasons for marking a replica as suspicious that are given by either the conveyor or the tracer aren't descriptive. This will be changed (in a different issue, see #5478), so that the error message causing the file to be suspicious will be given as the reason.

This change makes it possible to compare the checksum much quicker than currently possible. A new method will be created in core/replica.py that gets the reason (which will now be the error message) for which the conveyor or tracker declared the replica as suspicious. If there was a checksum mismatch, then this will be indicated in the error message.
@ChristophAmes ChristophAmes changed the title Change conveyor/tracer reason for suspicious file, implement checksum comparison in suspicious replica recoverer Recovery: Implement checksum comparison in suspicious replica recoverer Apr 20, 2022
ChristophAmes added a commit to ChristophAmes/rucio that referenced this issue Apr 20, 2022
@ChristophAmes
Recovery: Implement checksum comparison to suspicious replica recoverer
44b51d7 
rucio#5334

Before a suspicious file which is the last remaining copy is declared bad, its checksum should be compared to varify that it is corrupt.
A new method is added to /core/replica.py which retrieves the reason for which a replica was declared bad. If the reason is related
to a checksum problem, then the replica is declared bad.
ChristophAmes added a commit to ChristophAmes/rucio that referenced this issue May 13, 2022
@ChristophAmes
Recovery: Implement checksum comparison to suspicious replica recoverer
74de010 
rucio#5334

Before a suspicious file which is the last remaining copy is declared bad, its checksum should be compared to varify that it is corrupt.
A new method is added to /core/replica.py which retrieves the reason for which a replica was declared bad. If the reason is related
to a checksum problem, then the replica is declared bad.
ChristophAmes added a commit to ChristophAmes/rucio that referenced this issue May 16, 2022
@ChristophAmes
Recovery: Implement checksum comparison to suspicious replica recoverer
29261d6 
rucio#5334

Before a suspicious file which is the last remaining copy is declared bad, its checksum should be compared to varify that it is corrupt.
A new method is added to /core/replica.py which retrieves the reason for which a replica was declared bad. If the reason is related
to a checksum problem, then the replica is declared bad.
ChristophAmes added a commit to ChristophAmes/rucio that referenced this issue May 16, 2022
@ChristophAmes
Recovery: Implement checksum comparison to suspicious replica recoverer
a51118a 
rucio#5334

Before a suspicious file which is the last remaining copy is declared bad, its checksum should be compared to varify that it is corrupt.
A new method is added to /core/replica.py which retrieves the reason for which a replica was declared bad. If the reason is related
to a checksum problem, then the replica is declared bad.
ChristophAmes added a commit to ChristophAmes/rucio that referenced this issue May 16, 2022
@ChristophAmes
Recovery: Implement checksum comparison to suspicious replica recoverer
c40c399 
rucio#5334

Before a suspicious file which is the last remaining copy is declared bad, its checksum should be compared to varify that it is corrupt.
A new method is added to /core/replica.py which retrieves the reason for which a replica was declared bad. If the reason is related
to a checksum problem, then the replica is declared bad.
ChristophAmes added a commit to ChristophAmes/rucio that referenced this issue May 18, 2022
@ChristophAmes
Recovery: Implement checksum comparison to suspicious replica recoverer
d54d876 
rucio#5334

Before a suspicious file which is the last remaining copy is declared bad, its checksum should be compared to varify that it is corrupt.
A new method is added to /core/replica.py which retrieves the reason for which a replica was declared bad. If the reason is related
to a checksum problem, then the replica is declared bad.
ChristophAmes added a commit to ChristophAmes/rucio that referenced this issue May 19, 2022
@ChristophAmes
Recovery: Implement checksum comparison to suspicious replica recoverer
855b492 
rucio#5334

Before a suspicious file which is the last remaining copy is declared bad, its checksum should be compared to varify that it is corrupt.
A new method is added to /core/replica.py which retrieves the reason for which a replica was declared bad. If the reason is related
to a checksum problem, then the replica is declared bad.
bari12 added a commit that referenced this issue May 20, 2022
@bari12
Merge pull request #5555 from ChristophAmes/feature-5334-Implement_ch…
e0ab177 
…ecksum_comparison_to_suspicious_replica_recoverer

Recovery: Implement checksum comparison to suspicious replica recoverer #5334
bari12 pushed a commit that referenced this issue May 20, 2022
@ChristophAmes @bari12
Recovery: Implement checksum comparison to suspicious replica recoverer
2f7423e 
#5334

Before a suspicious file which is the last remaining copy is declared bad, its checksum should be compared to varify that it is corrupt.
A new method is added to /core/replica.py which retrieves the reason for which a replica was declared bad. If the reason is related
to a checksum problem, then the replica is declared bad.
@bari12 bari12 changed the title Recovery: Implement checksum comparison in suspicious replica recoverer Implement checksum comparison in suspicious replica recoverer May 20, 2022
@bari12 bari12 added this to the 1.28.5 milestone May 20, 2022
@bari12 bari12 closed this as completed May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristophAmes ChristophAmes

Labels
feature Recovery
Projects
None yet
Milestone
1.28.5
Development

No branches or pull requests
2 participants
@bari12 @ChristophAmes