Incorrect FTS transfer_link on messages sent by receiver

[rcarpa]

Motivation

The transfer_link is generated here:

rucio/lib/rucio/transfertool/fts3.py

Line 396 in 07fb277

return '%s/fts3/ftsmon/#/job/%s' % (self.external_host.replace('8446', '8449'), self._transfer_id)

Which uses external_host as passed into the constructor:

rucio/lib/rucio/daemons/conveyor/receiver.py

Line 83 in 876904d

external_host = msg.get('endpnt', None)

This field comes from an FTS config file parameter, which may not be initialized the same way as rucio expects it to be. As a result, rucio will generate monitoring links which don't point to a correct fts fqdn.

Modification

Under normal operation, when we get a notification from FTS about a transfer completion, we know about the transfer and we retrieve it from the database. It doesn't cost us anything to use the request.external_host field from the database, which has the correct format.

We can ignore the ocurances when it's not the case. It means that we got a notification from FTS about a transfer submitted by rucio, but about which rucio doesn't know anything.... we would have bigger problems to investigate in such case than a wrong monitoring link :D