WebDAV protocol XML parser doesn't handle XML namespaces correctly #5700
Comments
akselaase
added a commit
to akselaase/rucio
that referenced
this issue
Jul 6, 2022
akselaase
added a commit
to akselaase/rucio
that referenced
this issue
Jul 6, 2022
…cio#5700, fix rucio#5308 As described in rucio#5700, the parser for the WebDAV server responses had issues with namespace handling. This caused Rucio to misinterpret responses from for instance the Apache DAV module. Changing the implementation to use Python's xml.etree.ElementTree fixes this issue. This PR also includes a fix for rucio#5308, in which Rucio doesn't properly handle DAV servers with path prefixes.
akselaase
added a commit
to akselaase/rucio
that referenced
this issue
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Motivation
The XML response parser in the WebDAV implementation does not properly handle resolution of different XML namespaces.
RFC 4918 specifies that the response to a PROPFIND request will use tags in the
DAV:XML namespace, which is usually shortened to justD:by settingxmlns:D="DAV:"on theD:multistatustag. The XML parsing inwebdav.pydepends on thisD:alias, which causes it to mishandle responses from for instance the Apache DAV module which often useslp1:instead by settingxmlns:lp1="DAV:".Issue occurred when working on #5308 due to trying to test with an Apache WebDAV server.
Modification
Use Python's
xml.etree.elementtreeto properly resolve namespaces and traverse the DAV response, instead of comparing raw string values.The text was updated successfully, but these errors were encountered: