Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading warning in srm scheme #575

Closed
nataliaratnikova opened this issue Feb 1, 2018 · 1 comment
Closed

Misleading warning in srm scheme #575

nataliaratnikova opened this issue Feb 1, 2018 · 1 comment

Comments

@nataliaratnikova
Copy link
Contributor

Motivation

The srm scheme currently requires space_token as extended_attribute, however when space_token is not set, rucio complains about extended_attributes and web_service_path not specfied.

Modification

Happens in these lines:

rucio/lib/rucio/core/rse.py

Lines 691 to 692 in 5fa4bb2

if ('space_token' not in parameter['extended_attributes']) or ('web_service_path' not in parameter['extended_attributes']):
raise exception.InvalidObject('Missing values! For SRM, extended_attributes and web_service_path must be specified')

Expected behavior

Ideally , space_token would be an optional attribute, and if not used, no spacetoken should be passed to FTS transfer job submission command. See also #574

@bbockelm
Copy link
Contributor

Note - this is fixed in next but not in master. So, I think this becomes a backport exercise.

bbockelm added a commit to bbockelm/rucio that referenced this issue Feb 13, 2018
Outside ATLAS (particularly, for CMS), space tokens are optional at
some SRM endpoints.  Previously, for rucio#574, we fixed the conveyor
to handle empty space tokens.  Additionally, the fix for the client-side
of rucio#575 got mistakenly wrapped up in rucio#570 (pluggable LFN2PFN) and put
into `next`.

This is the missing piece for `master`.
@bari12 bari12 added this to the 1.14.10 milestone Feb 14, 2018
@bari12 bari12 closed this as completed Feb 14, 2018
bari12 added a commit that referenced this issue Feb 14, 2018
@bari12 bari12 modified the milestones: 1.14.12, 1.15.0 Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants