Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transfer-queued message does not include the correct services #5772

Closed
bari12 opened this issue Aug 1, 2022 · 0 comments · Fixed by #5803
Closed

transfer-queued message does not include the correct services #5772

bari12 opened this issue Aug 1, 2022 · 0 comments · Fixed by #5803
Assignees
Milestone

Comments

@bari12
Copy link
Member

bari12 commented Aug 1, 2022

Motivation

With all messages handled by the new hermes2 logic, messages get attached to the services defined in the configuration. This is then always handled when calling add_message. However, the queue_requests workflow does not call add_message but instead bulk inserts the messages to the database, not respecting the services logic.

for messages_chunk in chunks(messages, 1000):
session.bulk_insert_mappings(models.Message, messages_chunk)

Modification

Either add_message needs to be called here, or better create a bulk logic for add_message which can be called here to have the advantage of the bulk inserts.

bari12 added a commit that referenced this issue Aug 16, 2022
…e_does_not_include_the_correct_services

Transfer queued message does not include the correct services : Closes #5772
@bari12 bari12 added this to the 1.29.3 milestone Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants