Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reaper not processing all Epoch tombstone replicas when no space is needed #5816

Closed
cserf opened this issue Aug 19, 2022 · 3 comments
Closed

Reaper not processing all Epoch tombstone replicas when no space is needed #5816

cserf opened this issue Aug 19, 2022 · 3 comments
Assignees
@cserf
Labels
bug Deletion patch
Milestone
1.29.4

Comments

@cserf
Copy link
Contributor

cserf commented Aug 19, 2022

Motivation

Reaper not processing all Epoch tombstone replicas when no space is needed
@cserf cserf self-assigned this Aug 19, 2022
@rcarpa
Copy link
Contributor

rcarpa commented Aug 22, 2022 •
edited

I always thought this is "by design". I think we even have tests ensuring this is the case.

@rcarpa
Copy link
Contributor

rcarpa commented Aug 22, 2022

rucio/lib/rucio/tests/test_reaper.py

Line 93 in 9ae4c7c

# Check first if the reaper does not delete anything if no space is needed

@bari12
Copy link
Member

bari12 commented Aug 22, 2022

The Epoch ones are "special". To flag a replica as "needs to be deleted right now" we just give them an epoch tombstone (Since we don't have a special flag for it otherwise)

@cserf cserf mentioned this issue Aug 25, 2022
Merged
@bari12 bari12 closed this as completed in 88907ad Sep 5, 2022
bari12 added a commit that referenced this issue Sep 5, 2022
@bari12
Merge pull request #5836 from cserf/patch-5816-Reaper_not_processing_…
b78a9e8 
…all_Epoch_tombstone_replicas_when_no_space_is_needed

 Reaper not processing all Epoch tombstone replicas when no space is needed : Closes #5816
bari12 pushed a commit that referenced this issue Sep 5, 2022
@cserf @bari12
Reaper not processing all Epoch tombstone replicas when no space is n…
2201ee8 
…eeded : Closes #5816
@bari12 bari12 added this to the 1.29.4 milestone Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cserf cserf

Labels
bug Deletion patch
Projects
None yet
Milestone
1.29.4
Development

No branches or pull requests
3 participants
@bari12 @rcarpa @cserf