Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webdav Protocol stat does not return data as specified #5977

Closed
ThePhisch opened this issue Nov 15, 2022 · 2 comments
Closed

Webdav Protocol stat does not return data as specified #5977

ThePhisch opened this issue Nov 15, 2022 · 2 comments
Assignees
@Kwaizer
Labels
bug good first issue Protocols
Milestone
32.3.1

Comments

@ThePhisch
Copy link
Contributor

Motivation

The docstring for rse/protocols/webdav.py::Default::stat states that a dict with two keys (filesize and adler32) are returned. This matches the implementations of stat in the SSH and xrootd protocols (although these protocols do not explicitly say that it is adler32 but any one of GLOBALLY_SUPPORTED_CHECKSUMS. At the moment, the implementation of webdav only returns the filesize.

Modification

Add an entry to the dictionary containing the checksum.
@Kwaizer Kwaizer self-assigned this Jul 9, 2023
Kwaizer added a commit to Kwaizer/rucio that referenced this issue Jul 10, 2023
@Kwaizer
Protocols: Add an to the dictionary rucio#5977
fc749ba
Kwaizer added a commit to Kwaizer/rucio that referenced this issue Jul 10, 2023
@Kwaizer
Protocols: Adding an entry to the dictionary rucio#5977
e8f9a94
Kwaizer added a commit to Kwaizer/rucio that referenced this issue Jul 20, 2023
@Kwaizer
Protocols: Reediting an entry to the dictionary rucio#5977
2aaceec
Kwaizer added a commit to Kwaizer/rucio that referenced this issue Aug 14, 2023
@Kwaizer
Protocols: Removing mentioning of adler32 in webdav.py rucio#5977
12f867c
@mohitsatr
Copy link

hi @Kwaizer, have you solved this one ?

@Kwaizer
Copy link
Member

Kwaizer commented Aug 21, 2023 •
edited

hi @mohitsatr, I'm waiting for a review.

bari12 pushed a commit that referenced this issue Sep 20, 2023
@Kwaizer @bari12
Protocols: Removing mentioning of adler32 in webdav.py #5977
c3ded05
bari12 pushed a commit that referenced this issue Sep 20, 2023
@Kwaizer @bari12
Protocols: Removing mentioning of adler32 in webdav.py #5977
ebd7556
@bari12 bari12 added this to the 32.4.0 / 32.3.1 milestone Sep 20, 2023
@bari12 bari12 closed this as completed Sep 20, 2023
@bari12 bari12 added the bug label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kwaizer Kwaizer

Labels
bug good first issue Protocols
Projects
None yet
Milestone
32.3.1
Development

No branches or pull requests
4 participants
@bari12 @ThePhisch @mohitsatr @Kwaizer