Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading warnings when submitting a Lifetime Model exception with an input file containing duplicate entries #6146

Closed
dchristidis opened this issue Mar 23, 2023 · 0 comments
Assignees
Milestone

Comments

@dchristidis
Copy link
Contributor

Description

If the user is submitting a Lifetime Model exception request using the CLI and the input file contains some dataset multiple times, then they will see some warning about datasets not existing.

Instead, it should show a warning that the entry is being removed for being a duplicate (so that, when reviewing the summary, one can easily understand the difference between total and successfully-submitted DIDs).

Steps to reproduce

$ cat covfefe
mc16_13TeV.364677.Sherpa_CT10_CT14nnlo_CSShower_2to2jets_JZ1W.deriv.DAOD_STDM11.e6997_e5984_s3126_r10201_r10210_p4615_tid26084487_00
mc16_13TeV.364677.Sherpa_CT10_CT14nnlo_CSShower_2to2jets_JZ1W.deriv.DAOD_STDM11.e6997_e5984_s3126_r10201_r10210_p4615_tid26084487_00
$ rucio add-lifetime-exception --inputfile covfefe --reason 'For testing purposed; please ignore.' --expiration 2024-01-01
2023-03-23 08:09:13,033	INFO	mc16_13TeV:mc16_13TeV.364677.Sherpa_CT10_CT14nnlo_CSShower_2to2jets_JZ1W.deriv.DAOD_STDM11.e6997_e5984_s3126_r10201_r10210_p4615_tid26084487_00 will be declared
2023-03-23 08:09:13,033	WARNING	mc16_13TeV:mc16_13TeV.364677.Sherpa_CT10_CT14nnlo_CSShower_2to2jets_JZ1W.deriv.DAOD_STDM11.e6997_e5984_s3126_r10201_r10210_p4615_tid26084487_00 does not exist
2023-03-23 08:09:13,066	INFO	Exception successfully submitted. Summary below
Total DIDs                                                                                                2
DID not submitted because it is a file                                                                    0
DID not submitted because it is a container                                                               0
DID not submitted because it is not part of the lifetime campaign                                         0
DID successfully submitted                                                                                1

Rucio Version

No response

Additional Information

No response

cserf added a commit to cserf/rucio that referenced this issue Apr 19, 2023
…n input file containing duplicate entries : Closes rucio#6146
cserf added a commit to cserf/rucio that referenced this issue Apr 19, 2023
…n input file containing duplicate entries : Closes rucio#6146
cserf added a commit to cserf/rucio that referenced this issue Apr 26, 2023
cserf added a commit to cserf/rucio that referenced this issue Apr 26, 2023
cserf added a commit to cserf/rucio that referenced this issue Apr 28, 2023
@bari12 bari12 closed this as completed in e595093 May 2, 2023
@bari12 bari12 added this to the 1.31.2 milestone May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants