Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Virtual Placement return only complete dataset replicas #6159

Closed
dchristidis opened this issue Apr 4, 2023 · 5 comments · Fixed by #6174
Closed

Make Virtual Placement return only complete dataset replicas #6159

dchristidis opened this issue Apr 4, 2023 · 5 comments · Fixed by #6174
Assignees
Milestone

Comments

@dchristidis
Copy link
Contributor

Description

for reply in list_dataset_replicas(scope=scope, name=name, deep=deep, session=session):
rse_info = rsemgr.get_rse_info(rse=reply['rse'], vo=scope.vo, session=session)
if rse_info['rse_type'] == 'TAPE':
continue
for prot in rse_info['protocols']:
if prot['scheme'] == 'root' and prot['domains']['wan']['read']:
accessible_replica_exists = True
break
if accessible_replica_exists is True:
break

This checks that the dataset exists on a disk RSE which has a root:// protocol for reading. It should also check that the dataset is fully replicated.

Reported by R. Walker.

Motivation

No response

Change

No response

@bari12
Copy link
Member

bari12 commented Apr 4, 2023

@ivukotic are you available to implement this change?

@bari12 bari12 added the Replicas label Apr 4, 2023
@ivukotic
Copy link
Contributor

ivukotic commented Apr 4, 2023

I could do it if I would know how to ask if the replica is complete... can you please let me know?

@bari12
Copy link
Member

bari12 commented Apr 4, 2023

Should be an easy change in principle. In the loop above, list_dataset_replicas should give you all the necessary information already, including a state entry (AVAILABLE/UNAVAILABLE)

@ivukotic
Copy link
Contributor

ivukotic commented Apr 4, 2023

ah OK. I will try to do it today.

@ivukotic
Copy link
Contributor

ivukotic commented Apr 6, 2023

solved by: #6162

ivukotic added a commit to ivukotic/rucio that referenced this issue Apr 6, 2023
ivukotic added a commit to ivukotic/rucio that referenced this issue Apr 6, 2023
ivukotic added a commit to ivukotic/rucio that referenced this issue Apr 11, 2023
ivukotic added a commit to ivukotic/rucio that referenced this issue Apr 11, 2023
ivukotic added a commit to ivukotic/rucio that referenced this issue Apr 11, 2023
ivukotic added a commit to ivukotic/rucio that referenced this issue Apr 11, 2023
@bari12 bari12 added this to the 1.31.1 milestone Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants