Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

declare_bad_file_replicas does not pass rse_id to the policy module #6339

Closed
ivmfnal opened this issue Sep 28, 2023 · 0 comments
Closed

declare_bad_file_replicas does not pass rse_id to the policy module #6339

ivmfnal opened this issue Sep 28, 2023 · 0 comments
Assignees
@ivmfnal
Labels
bug Policies
Milestone
32.6.0

Comments

@ivmfnal
Copy link
Contributor

ivmfnal commented Sep 28, 2023

Description

Currently, the api.declare_bad_file_replicas() does not pass rse_id to the permission.has_permission() function:

https://github.com/ivmfnal/rucio/blob/fc3973a83b9d658fba5ef9f645f5816a594d4586/lib/rucio/api/replica.py#L88C1-L92C1

CMS needs rse_id to be passed to the permissions module to be able to determine whether the user has permissions to declare bad replicas in the RSE

Steps to reproduce

I think this is obvious from the code.
Too difficult to reproduce.

Rucio Version

No response

Additional Information

No response
@ivmfnal ivmfnal added the bug label Sep 28, 2023
@ivmfnal ivmfnal self-assigned this Sep 28, 2023
@ivmfnal ivmfnal mentioned this issue Sep 28, 2023
Closed
@bari12 bari12 added the Policies label Oct 4, 2023
ivmfnal added a commit to ivmfnal/rucio that referenced this issue Oct 11, 2023
@ivmfnal
policies: pass RSE ids to the permissions function when declaring bad…
dcda4be 
… repliacas rucio#6339
ivmfnal added a commit to ivmfnal/rucio that referenced this issue Oct 11, 2023
@ivmfnal
policies: pass RSE ids to the permissions function when declaring bad…
cefd5a8 
… repliacas rucio#6339
ivmfnal added a commit to ivmfnal/rucio that referenced this issue Oct 11, 2023
@ivmfnal
policies: pass RSE ids to the permissions function when declaring bad…
442ed04 
… repliacas rucio#6339

added traceback in case of uncaught exception in the web server BadReplicas
ivmfnal added a commit to ivmfnal/rucio that referenced this issue Oct 11, 2023
@ivmfnal
policies: pass RSE ids to the permissions function when declaring bad…
209e106 
… repliacas rucio#6339

added traceback in case of uncaught exception in the web server BadReplicas
ivmfnal added a commit to ivmfnal/rucio that referenced this issue Oct 11, 2023
@ivmfnal
policies: pass RSE ids to the permissions function when declaring bad…
0608a12 
… repliacas rucio#6339

added traceback in case of uncaught exception in the web server BadReplicas
ivmfnal added a commit to ivmfnal/rucio that referenced this issue Oct 12, 2023
@ivmfnal
policies: pass RSE ids to the permissions function when declaring bad…
f8fcac3 
… repliacas rucio#6339

added traceback in case of uncaught exception in the web server BadReplicas
ivmfnal added a commit to ivmfnal/rucio that referenced this issue Oct 12, 2023
@ivmfnal
policies: pass RSE ids to the permissions function when declaring bad…
28ace52 
… repliacas rucio#6339

added traceback in case of uncaught exception in the web server BadReplicas

add debug output when for an uncaught exception in BadReplicas.post()
ivmfnal added a commit to ivmfnal/rucio that referenced this issue Oct 14, 2023
@ivmfnal
policies: pass RSE ids to the permissions function when declaring bad…
dc99961 
… repliacas rucio#6339

added traceback in case of uncaught exception in the web server BadReplicas

add debug output when for an uncaught exception in BadReplicas.post()
ivmfnal added a commit to ivmfnal/rucio that referenced this issue Oct 15, 2023
@ivmfnal
policies: pass RSE ids to the permissions function when declaring bad…
524208d 
… repliacas rucio#6339

added traceback in case of uncaught exception in the web server BadReplicas

add debug output when for an uncaught exception in BadReplicas.post()
ivmfnal added a commit to ivmfnal/rucio that referenced this issue Oct 15, 2023
@ivmfnal
policies: pass RSE ids to the permissions function when declaring bad…
99b8be1 
… repliacas rucio#6339

added traceback in case of uncaught exception in the web server BadReplicas

add debug output when for an uncaught exception in BadReplicas.post()
@bari12 bari12 mentioned this issue Nov 1, 2023
Merged
ivmfnal added a commit to ivmfnal/rucio that referenced this issue Nov 2, 2023
@ivmfnal
Policies: pass RSE ids to has_permissionfrom api.declare_bad_file_rep…
ec0e1d2 
…licas Fix rucio#6339
ivmfnal added a commit to ivmfnal/rucio that referenced this issue Nov 8, 2023
@ivmfnal
Policies: pass RSE ids to has_permissionfrom api.declare_bad_file_rep…
55d2665 
…licas Fix rucio#6339

print exception if not InvalidType
ivmfnal added a commit to ivmfnal/rucio that referenced this issue Nov 8, 2023
@ivmfnal
Policies: pass RSE ids to has_permissionfrom api.declare_bad_file_rep…
664a9f9 
…licas Fix rucio#6339

print exception if not InvalidType
ivmfnal added a commit to ivmfnal/rucio that referenced this issue Nov 9, 2023
@ivmfnal
Policies: pass RSE ids to has_permissionfrom api.declare_bad_file_rep…
397d085 
…licas Fix rucio#6339

print exception if not InvalidType
ivmfnal added a commit to ivmfnal/rucio that referenced this issue Nov 10, 2023
@ivmfnal
Policies: pass RSE ids to has_permissionfrom api.declare_bad_file_rep…
62c2b33 
…licas Fix rucio#6339

print exception if not InvalidType
ivmfnal added a commit to ivmfnal/rucio that referenced this issue Nov 10, 2023
@ivmfnal
Policies: pass RSE ids to has_permissionfrom api.declare_bad_file_rep…
de4bec7 
…licas Fix rucio#6339
ivmfnal added a commit to ivmfnal/rucio that referenced this issue Nov 10, 2023
@ivmfnal
Policies: pass RSE ids to has_permissionfrom api.declare_bad_file_rep…
647f56d 
…licas Fix rucio#6339
@bari12 bari12 closed this as completed in 7bbdf63 Nov 15, 2023
bari12 pushed a commit that referenced this issue Nov 15, 2023
@ivmfnal @bari12
Policies: pass RSE ids to has_permissionfrom api.declare_bad_file_rep…
85e0c5f 
…licas Fix #6339
@bari12 bari12 added this to the 23.5.2 / 32.6.0 milestone Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivmfnal ivmfnal

Labels
bug Policies
Projects
None yet
Milestone
32.6.0
Development

No branches or pull requests
2 participants
@bari12 @ivmfnal