Unused subscription name in subscriptions/<account>/<name>/Rules/States endpoint

[maany]

Description

The endpoint requires specifying a subscription name

rucio/lib/rucio/web/rest/flaskapi/v1/subscriptions.py

Lines 626 to 627 in fc3973a

	states_view = States.as_view('states')
	bp.add_url_rule('/<account>/<name>/Rules/States', view_func=states_view, methods=['get', ])

However, it returns rule states for all subscriptions for the provided account

rucio/lib/rucio/web/rest/flaskapi/v1/subscriptions.py

Lines 532 to 534 in fc3973a

	def generate(vo):
	for row in list_subscription_rule_states(account=account, vo=vo):
	yield dumps(row, cls=APIEncoder) + '\n'

So technically, a request to https://rucio-server.com/subscriptions/jdoe/HOLWAMJFDRSI/Rules/States is a valid request

Steps to reproduce

Make a request to
https://rucio-server.com/subscriptions/validAccount/invalidSubscription/Rules/Satetes

Rucio Version

32.x

Additional Information

Depending on how this feature is fixed, we might have to make changes in the new webui. We also need to make sure that the change is backward compatible with older clients.

[bari12]

@cserf do you remember the reasoning here, or was this just a mistake?

[cserf]

That's a mistake.

[alexanderrichards]

Am I missing something or is this fix simply a matter of parsing the name to the api thusly:

def generate(vo):
-    for row in list_subscription_rule_states(account=account, vo=vo):
+    for row in list_subscription_rule_states(name=name, account=account, vo=vo):
        yield dumps(row, cls=APIEncoder) + '\n'

If so, I can do this right away