Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider refactoring daemons into classes with a base Daemon class #6478

Open
rdimaio opened this issue Jan 22, 2024 · 0 comments
Open

Consider refactoring daemons into classes with a base Daemon class #6478

rdimaio opened this issue Jan 22, 2024 · 0 comments
Assignees
@rdimaio
Labels
Core & Internals enhancement

Comments

@rdimaio
Copy link
Contributor

rdimaio commented Jan 22, 2024

Looking at the Rucio daemons (https://github.com/rucio/rucio/tree/37bb888fe6c0af8cb74cea7f36e087468185cbb8/lib/rucio/daemons), there's a few functions that are in common to many daemons. For example, run, stop and run_once are used in:

It might make sense to abstract these functions into a parent class BaseDaemon to avoid replication where possible.
@rdimaio rdimaio self-assigned this Jan 22, 2024
@rdimaio rdimaio changed the title Consider refactoring daemons into classes with a BaseDaemon base class Consider refactoring daemons into classes with a base Daemon class Jan 25, 2024
This was referenced Jan 25, 2024
Closed
Open
rdimaio added a commit to rdimaio/rucio that referenced this issue Feb 2, 2024
@rdimaio
Create base Daemon class and refactor Undertaker to inherit from base…
4b39ed3 
… class; rucio#6478

Initial commit where base class Daemon is created. As an initial test,
Undertaker inherits from Daemon. If tests pass, other daemons
can also be refactored to inherit from Daemon.
rdimaio added a commit to rdimaio/rucio that referenced this issue Feb 2, 2024
@rdimaio
Refactor Reaper to inherit from base Daemon class; rucio#6478
1d85a40
rdimaio added a commit to rdimaio/rucio that referenced this issue Feb 2, 2024
@rdimaio
Refactor Judge Repairer to inherit from Daemon base class; rucio#6478
48fc910
rdimaio added a commit to rdimaio/rucio that referenced this issue Feb 2, 2024
@rdimaio
Refactor Abacus Account to inherit from base Daemon class; rucio#6478
8eb51c8
rdimaio added a commit to rdimaio/rucio that referenced this issue Feb 15, 2024
@rdimaio
Create base Daemon class and refactor Undertaker to inherit from base…
52b217e 
… class; rucio#6478

Initial commit where base class Daemon is created. As an initial test,
Undertaker inherits from Daemon. If tests pass, other daemons
can also be refactored to inherit from Daemon.
rdimaio added a commit to rdimaio/rucio that referenced this issue Feb 15, 2024
@rdimaio
Refactor Reaper to inherit from base Daemon class; rucio#6478
ee265e6
rdimaio added a commit to rdimaio/rucio that referenced this issue Feb 15, 2024
@rdimaio
Refactor Judge Repairer to inherit from Daemon base class; rucio#6478
5fcff6c
rdimaio added a commit to rdimaio/rucio that referenced this issue Feb 15, 2024
@rdimaio
Refactor Abacus Account to inherit from base Daemon class; rucio#6478
1cbb3d2
rdimaio added a commit to rdimaio/rucio that referenced this issue Feb 15, 2024
@rdimaio
Refactor Abacus Account to inherit from base Daemon class; rucio#6478
a4ff256
rdimaio added a commit to rdimaio/rucio that referenced this issue Feb 15, 2024
@rdimaio
Refactor Abacus Account to inherit from base Daemon class; rucio#6478
d45c5ad
rdimaio added a commit to rdimaio/rucio that referenced this issue Feb 17, 2024
@rdimaio
Refactor Abacus RSE to inherit from base Daemon class; rucio#6478
497f1ba
rdimaio added a commit to rdimaio/rucio that referenced this issue Feb 17, 2024
@rdimaio
Refactor Abacus Collection Replica to inherit from base Daemon class; r…
0f14a5a 
…ucio#6478
rdimaio added a commit to rdimaio/rucio that referenced this issue Feb 17, 2024
@rdimaio
Refactor Atropos to inherit from base Daemon class; rucio#6478
c905122
rdimaio added a commit to rdimaio/rucio that referenced this issue Feb 17, 2024
@rdimaio
Refactor Automatix to inherit from base Daemon class; rucio#6478
42c6ff1
rdimaio added a commit to rdimaio/rucio that referenced this issue Feb 17, 2024
@rdimaio
Refactor Transmogrifier to inherit from base Daemon class; rucio#6478
9ac49a0
rdimaio added a commit to rdimaio/rucio that referenced this issue Feb 17, 2024
@rdimaio
Refactor OAuthManager to inherit from base Daemon class; rucio#6478
70bb68e
rdimaio added a commit to rdimaio/rucio that referenced this issue Feb 29, 2024
@rdimaio
Daemons: Create base Daemon class and refactor Undertaker to inherit …
6e9444a 
…from base class; rucio#6478

Initial commit where base class Daemon is created. As an initial test,
Undertaker inherits from Daemon. If tests pass, other daemons
can also be refactored to inherit from Daemon.
rdimaio added a commit to rdimaio/rucio that referenced this issue Feb 29, 2024
@rdimaio
Daemons: Refactor Reaper to inherit from base Daemon class; rucio#6478
5dd4d02
rdimaio added a commit to rdimaio/rucio that referenced this issue Feb 29, 2024
@rdimaio
Daemons: Refactor Judge Repairer to inherit from Daemon base class; r…
b298314 
…ucio#6478
rdimaio added a commit to rdimaio/rucio that referenced this issue Feb 29, 2024
@rdimaio
Daemons: Refactor Abacus Account to inherit from base Daemon class; r…
e1b2d36 
…ucio#6478
rdimaio added a commit to rdimaio/rucio that referenced this issue Mar 12, 2024
@rdimaio
Daemons: Create base Daemon class and refactor Undertaker to inherit …
90e3fb8 
…from base class; rucio#6478

Initial commit where base class Daemon is created. As an initial test,
Undertaker inherits from Daemon. If tests pass, other daemons
can also be refactored to inherit from Daemon.
rdimaio added a commit to rdimaio/rucio that referenced this issue Mar 12, 2024
@rdimaio
Daemons: Refactor Reaper to inherit from base Daemon class; rucio#6478
e404635
rdimaio added a commit to rdimaio/rucio that referenced this issue Mar 12, 2024
@rdimaio
Daemons: Refactor Judge Repairer to inherit from Daemon base class; r…
fa57fcf 
…ucio#6478
rdimaio added a commit to rdimaio/rucio that referenced this issue Mar 12, 2024
@rdimaio
Daemons: Refactor Abacus Account to inherit from base Daemon class; r…
fe86b52 
…ucio#6478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rdimaio rdimaio

Labels
Core & Internals enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bari12 @rdimaio