Decide on Message format for ActiveMQ Message to AMI

[bari12]

Do we need two different messages? One for Dataset one for Container or is the same one sufficient?

Migrated from JIRA RUCIO-2810

[vingar]

Is it related to the INCOMPLETE message ? Do we have another issue related to it ?

Motivation:
When a dataset starts being deleted, If its state change to INCOMPLETE from a previous state != INCOMPLETE, then a message is produced:

        add_message('INCOMPLETE', {'scope': scope, 'name': name})

[bari12]

Yes, the epic issue for this is #69. I just noticed though, we added the INCOMPLETE state in the schema.sql, but not in models.py or constants.py yet.

[vingar]

I checked on next and could not find the constants change ? models.py is not necessary.

[bari12]

Yes, as I said, it's not there 😄

[vingar]

but I did the merge request (100% sure)...

[bari12]

It doesn't seem to be in there. Only schema.sql and the migrate_repo file.
bf36f63

[bari12]

But just coming back to the original question. I think one message is enough, no need to have one for DATASET and one for CONTAINER.

[vingar]

did_type in the message ?

[bari12]

Yes, I think so. To some extent it is redundant, as e.g. AMI would know it anyway, but maybe this is consumed by other services too which do not necessarily know.

[vingar]

issue #68 is about 'Protect storage from too many requests ' ?

[bari12]

You mean about the epic issue link above? I accidentally linked #68 first, but then corrected to #69; Maybe in your eMail it still says the first version.