Release management: More work on travis (Fix issues #1009 #1017 #1017 #1018 #1019 #1020 #1012 #1022 #1024 #1025) #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vingar
force-pushed
the
patch-1009-Add_python2_7_conditional_requirements_to_core_dependencies_to_support_pip_py3_installation
branch
2 times, most recently
from
d6638da
to
7419e8a
Compare
…pendencies to support pip py3 installation (Fix issue rucio#1009)
vingar
force-pushed
the
patch-1009-Add_python2_7_conditional_requirements_to_core_dependencies_to_support_pip_py3_installation
branch
from
7419e8a
to
d866dd0
Compare
|
For me this is good to go, but as it is quite a big PR, if anyone else wants to have a look, please do it today, I will merge tomorrow/tonight. |
|
Looks good to me. Just one improvement, it might be worth to run the flake/syntax check first, before spawning all the subjobs? Because if that one doesn't work, then we can fail quickly and not need to spawn all the matrix jobs. |
|
It's the concept of build stages: https://docs.travis-ci.com/user/build-stages/ |
mlassnig
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.