Clients: switched bin/rucio download to API Fix #490 #567 #669 #1222 #1263 #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 15, 2018 14:40
bari12
reviewed
Jun 18, 2018
| if force_scheme: | ||
| schemes = force_scheme if isinstance(force_scheme, list) else [force_scheme] | ||
| else: | ||
| schemes = ['davs', 'gsiftp', 'https', 'root', 'srm', 'file'] |
There was a problem hiding this comment.
As just discussed, so that this is documented here too. This hardcoding of schemes is bad. I understand that this is how the list_replicas with metalink=True requires it, but it really shouldn't. The default behaviour of list_replicas should be if schemes = [] is given, all protocols should be supplied. That's the only way how we can make proper protocol failover work. Due to release considerations, I am in favour of merging this, but we should address this eventually. See #1262
TWAtGH
changed the title
bari12
approved these changes
Jun 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clients: switched bin/rucio download to API Fix #490 #567 #669 #1222