Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix bad exception for set global quota; Fix #3199 #3657

Conversation

bari12
Copy link
Member

@bari12 bari12 commented May 27, 2020

Core: Fix bad exception for set global quota; Fix #3199

@bari12
Copy link
Member Author

bari12 commented May 28, 2020

Ok, this apparently fixes a problem, but not the problem @davidgcameron was describing in the ticket. ;-)

@bari12
Copy link
Member Author

bari12 commented May 28, 2020

The underlying error is

[Thu May 28 14:42:39.882259 2020] [:error] [pid 5505:tid 140685594834688] Traceback (most recent call last):
[Thu May 28 14:42:39.882337 2020] [:error] [pid 5505:tid 140685594834688]   File "/usr/lib/python2.7/site-packages/rucio/web/rest/account_limit.py", line 158, in POST
[Thu May 28 14:42:39.882354 2020] [:error] [pid 5505:tid 140685594834688]     set_global_account_limit(account=account, rse_expression=rse_expression, bytes=bytes, issuer=ctx.env.get('issu
er'))
[Thu May 28 14:42:39.882357 2020] [:error] [pid 5505:tid 140685594834688]   File "/usr/lib/python2.7/site-packages/rucio/api/account_limit.py", line 140, in set_global_account_limit
[Thu May 28 14:42:39.882359 2020] [:error] [pid 5505:tid 140685594834688]     if not rucio.api.permission.has_permission(issuer=issuer, action='set_global_account_limit', kwargs=kwargs):
[Thu May 28 14:42:39.882382 2020] [:error] [pid 5505:tid 140685594834688]   File "/usr/lib/python2.7/site-packages/rucio/api/permission.py", line 65, in has_permission
[Thu May 28 14:42:39.882385 2020] [:error] [pid 5505:tid 140685594834688]     return permission.has_permission(issuer=issuer, action=action, kwargs=kwargs)
[Thu May 28 14:42:39.882388 2020] [:error] [pid 5505:tid 140685594834688]   File "/usr/lib/python2.7/site-packages/rucio/core/permission/atlas.py", line 123, in has_permission
[Thu May 28 14:42:39.882390 2020] [:error] [pid 5505:tid 140685594834688]     return perm.get(action, perm_default)(issuer=issuer, kwargs=kwargs)
[Thu May 28 14:42:39.882393 2020] [:error] [pid 5505:tid 140685594834688]   File "/usr/lib/python2.7/site-packages/rucio/core/permission/atlas.py", line 956, in perm_set_global_account_lim
it
[Thu May 28 14:42:39.882396 2020] [:error] [pid 5505:tid 140685594834688]     resolved_rse_countries = {list_rse_attributes(rse_id=rse['rse_id']).get('country') for rse in parse_expression
(kwargs['rse_exp'])}
[Thu May 28 14:42:39.882399 2020] [:error] [pid 5505:tid 140685594834688] KeyError: 'rse_exp'

mlassnig
mlassnig previously approved these changes May 29, 2020
@bari12 bari12 force-pushed the patch-3199-Core__Fix_bad_exception_for_set_global_account_limit branch from e288d94 to 527fa92 Compare May 29, 2020 15:21
@bari12 bari12 merged commit b810b9a into rucio:master Jun 2, 2020
@bari12 bari12 deleted the patch-3199-Core__Fix_bad_exception_for_set_global_account_limit branch September 4, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad exception when failing to set global account limit
2 participants