Clients: propagate selected domain in uploadclient. #4639 #4643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upload client has some logic to select the 'lan' domain if the client and rse 'site' are identical. This results into correctly selecting the `scheme` which can be used for a lan transfer. However, the domain is not enforced when the protocol object is latter created. This will result in using the default "wan" domain for the upload if a protocol with the same scheme is available on wan.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upload client has some logic to select the 'lan' domain if the
client and rse 'site' are identical. This results into correctly
selecting the
schemewhich can be used for a lan transfer.However, the domain is not enforced when the protocol object is
latter created. This will result in using the default "wan" domain
for the upload if a protocol with the same scheme is available on wan.