Core & Internals: simplify list_replica response creation. Closes #4473 #4691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlassnig
reviewed
Aug 11, 2021
|
|
||
| # don't forget to resolve parents for the last replica | ||
| if resolve_parents: | ||
| file['pfns'], file['rses'], file['states'] = {}, defaultdict(list), {} |
There was a problem hiding this comment.
the file['states'] was previously file['states'] = {rse_id: str(state.name if state else state)}, now it's just {}
on purpose?
There was a problem hiding this comment.
it is done a couple of lines below.
rcarpa
commented
Aug 11, 2021
|
|
||
| # don't forget to resolve parents for the last replica | ||
| if resolve_parents: | ||
| file['pfns'], file['rses'], file['states'] = {}, defaultdict(list), {} |
There was a problem hiding this comment.
it is done a couple of lines below.
|
|
||
| if rse_id: | ||
| file['rses'][rse_id] += list(set([tmp_pfn[0] for tmp_pfn in pfns])) | ||
| file['states'][rse_id] = str(state.name if state else state) |
…io#4473 Extract pfn/rse sorting to a separate function and call it in the 2 needed places (each time before yielding the file). Only resolve parents once per scope/name. As a side note, parents are not resolved for archives, but this never worked I don't see any regression about it in rucio#4473.
rcarpa
force-pushed
the
patch-4473-cosmetic_changes_list_replicas
branch
from
62e2560
to
7a00e4f
Compare
mlassnig
approved these changes
Sep 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract pfn/rse sorting to a separate function and call it in the 2
needed places (each time before yielding the file).
Only resolve parents once per scope/name. As a side note, parents
are not resolved for archives, but this never worked. I don't see
any regression about it in #4473.