Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Binding to specific IPs #4782 #4783

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

rak108
Copy link
Member

@rak108 rak108 commented Aug 16, 2021

This PR is in relation to issue #4782

@rcarpa
Copy link
Contributor

rcarpa commented Aug 18, 2021

Love it. Hope it works with podman. @bziemons , any opinion ?

@bziemons
Copy link
Member

The title of the PR doesn't really explain what is actually happening, but yes: I prefer binding to 127.0.0.1 only and it works with podman. I wanted to make this change before, but it was decided not to do it, because some wanted to reach the services (rest api, web-ui, database, ...) from outside the own host... not sure if that is still a requirement though

@rcarpa
Copy link
Contributor

rcarpa commented Aug 18, 2021

Weeeell, i'd say that those who want to do nasty things can maintain their own local config :)

@mlassnig
Copy link
Contributor

Well, at least we need it for the SSH container. For the rest, we should apply some good old democracy :-)

@rak108
Copy link
Member Author

rak108 commented Aug 18, 2021

@mlassnig ah alright, so should I close this PR?

@mlassnig
Copy link
Contributor

I'm voting for 127.0.0.1 on all of them :-)

@bziemons
Copy link
Member

I think it is decided then. There is no opposing vote ;)

@bari12
Copy link
Member

bari12 commented Aug 18, 2021

🥳

@bari12 bari12 merged commit 900b555 into rucio:master Aug 18, 2021
@rak108 rak108 deleted the patch-4782-specificbindingip branch August 20, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants