Client: Fix faulty list account usage test and untracked error #4870 #4894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4870 When an RSE was specified for the list-account-usage an KeyError: 'resolved_rses' was generated. The key does not exist in the underlying data model. The `test_list_account_usage` did not report the problem since the regex, which compared the actual output with the expected result, contained an unescaped `|` character. Hence the test produced a passing test, while a failing was expected.
joeldierkes
force-pushed
the
patch-4870-Traceback_when_requesting_the_global_account_usage_with_a_specific_RSE
branch
from
6cfa339
to
f8a943c
Compare
bari12
approved these changes
Oct 12, 2021
joeldierkes
deleted the
patch-4870-Traceback_when_requesting_the_global_account_usage_with_a_specific_RSE
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an RSE was specified for the list-account-usage an KeyError:
'resolved_rses' was generated. The key does not exist in the underlying data
model.
The
test_list_account_usagedid not report the problem since the regex, whichcompared the actual output with the expected result, contained an unescaped
|character. Hence the test produced a passing test, while a failing was expected.