-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: Add update_rule boost option #4634 #4929
Merged
bari12
merged 1 commit into
rucio:master
from
joeldierkes:feature-4634-Add_the_ability_to_quicken_the_transition_of_STUCK_rules_to_REPLICATING
Oct 29, 2021
Merged
Core: Add update_rule boost option #4634 #4929
bari12
merged 1 commit into
rucio:master
from
joeldierkes:feature-4634-Add_the_ability_to_quicken_the_transition_of_STUCK_rules_to_REPLICATING
Oct 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeldierkes
force-pushed
the
feature-4634-Add_the_ability_to_quicken_the_transition_of_STUCK_rules_to_REPLICATING
branch
2 times, most recently
from
October 22, 2021 07:55
7ee4fe6
to
8c827b8
Compare
joeldierkes
pushed a commit
to joeldierkes/rucio
that referenced
this pull request
Oct 25, 2021
…io#4929 The judge-evaluator is pausing the evaluation of dids (for a certain) time if certain error conditions are hit. A new case is introduced.
mlassnig
reviewed
Oct 26, 2021
bin/rucio
Outdated
@@ -2372,6 +2377,7 @@ You can filter by account:: | |||
update_rule_parser.add_argument('--cancel-requests', dest='cancel_requests', action='store_true', help='Cancel requests when setting rules to stuck.') | |||
update_rule_parser.add_argument('--priority', dest='priority', action='store', help='Priority of the requests of the rule.') | |||
update_rule_parser.add_argument('--child-rule-id', dest='child_rule_id', action='store', help='Child rule id of the rule.') | |||
update_rule_parser.add_argument('--boost-rule', dest='boost_rule', action='store_true', help='') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
help text :-)
lib/rucio/core/permission/atlas.py
Outdated
@@ -525,11 +528,8 @@ def perm_update_rule(issuer, kwargs): | |||
return True | |||
|
|||
# Only admin accounts can change account, state, priority of a rule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adapt comment :-)
The timeout between the retries of the transitioning of a rule from `STUCK` to `REPLICATING` are quite big. This commit introduces the feature `--boost-rule` to allow almost instant transition between the states.
joeldierkes
force-pushed
the
feature-4634-Add_the_ability_to_quicken_the_transition_of_STUCK_rules_to_REPLICATING
branch
from
October 26, 2021 13:31
8c827b8
to
e065ba8
Compare
mlassnig
approved these changes
Oct 27, 2021
joeldierkes
deleted the
feature-4634-Add_the_ability_to_quicken_the_transition_of_STUCK_rules_to_REPLICATING
branch
November 1, 2021 09:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeout between the retries of the transitioning of a rule from
STUCK
toREPLICATING
are quite big. This commit introduces a feature--boost-rule
toallow almost instant transition between the states.