Add header workflow integration 2 #5109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeldierkes
requested review from
bari12,
bziemons,
cserf,
dchristidis,
maany,
mlassnig and
rcarpa
as code owners
joeldierkes
changed the title
joeldierkes
force-pushed
the
add_header_workflow_integration
branch
from
eb7d6e2
to
122cef8
Compare
maany
reviewed
Dec 14, 2021
maany
reviewed
Dec 14, 2021
maany
reviewed
Dec 14, 2021
There was a problem hiding this comment.
Besides the comments I have already left, I noticed that some of the emails in the add-header.py:
Line 52 in d59c237
Line 74 in d59c237
look weird/temporary. I guess not all commits by these authors come from the same email address. Are we sure that we should be using these email addresses? WDYT @rcarpa @bari12
maany
reviewed
Dec 14, 2021
rcarpa
reviewed
Dec 14, 2021
joeldierkes
force-pushed
the
add_header_workflow_integration
branch
4 times, most recently
from
9e048ba
to
c4b995c
Compare
|
Is it strictly needed to re-touch every file (422 changes) or can't we just get this up to date over time? |
|
@maany and I discussed that, and the problem is that you have to get the diff between the PR and the master branch. I tried that first, but the commit SHA provided by GitHub Actions is not working properly when a commit is overwritten via a I also don't know anyone who has experience with that particular issue... |
joeldierkes
force-pushed
the
add_header_workflow_integration
branch
5 times, most recently
from
8e106ef
to
5ae6a50
Compare
joeldierkes
force-pushed
the
add_header_workflow_integration
branch
5 times, most recently
from
f490888
to
dde77e1
Compare
|
Okay, after @bari12 gave some hints on how to get the changed files in GItHub Actions the implementation now only checks the headers of the changed python files. |
maany
requested changes
Jan 14, 2022
There was a problem hiding this comment.
Nice work @joeldierkes ! Awesome to see we don't need to parse all the files on every pull request. I've left some minor comments. ;)
|
I really like the new version. Nice job! |
bari12
requested review from
maany
and removed request for
bari12 and
mlassnig
joeldierkes
force-pushed
the
add_header_workflow_integration
branch
7 times, most recently
from
8d3e6a0
to
9c163a2
Compare
added 2 commits
January 17, 2022 18:59
The `add_header` script needs to be run after an edit to determine the status of the header and, if necessary, change the header. This commit adds the check for the header to the CI/CD. This enforces the usage of the `add_header` script and ensures a healthy code base.
The `add_header` sript prints the correct header for a file if the `--in-place` argument is not provided. This is a good way to see changes, however due to this the output of the CI/CD is too verbose. This commit disables the output of the output of the correct header, if the `--check` option is provided. It also displays the number of files checked.
joeldierkes
force-pushed
the
add_header_workflow_integration
branch
from
9c163a2
to
c305e83
Compare
bari12
pushed a commit
that referenced
this pull request
Jan 20, 2022
* Add a header check to the CI Fix #4980 The `add_header` script needs to be run after an edit to determine the status of the header and, if necessary, change the header. This commit adds the check for the header to the CI/CD. This enforces the usage of the `add_header` script and ensures a healthy code base. * Change the output of the `add_header` script Fix #4980 The `add_header` sript prints the correct header for a file if the `--in-place` argument is not provided. This is a good way to see changes, however due to this the output of the CI/CD is too verbose. This commit disables the output of the output of the correct header, if the `--check` option is provided. It also displays the number of files checked.
piperov
pushed a commit
to piperov/rucio
that referenced
this pull request
Feb 25, 2022
* Add a header check to the CI Fix rucio#4980 The `add_header` script needs to be run after an edit to determine the status of the header and, if necessary, change the header. This commit adds the check for the header to the CI/CD. This enforces the usage of the `add_header` script and ensures a healthy code base. * Change the output of the `add_header` script Fix rucio#4980 The `add_header` sript prints the correct header for a file if the `--in-place` argument is not provided. This is a good way to see changes, however due to this the output of the CI/CD is too verbose. This commit disables the output of the output of the correct header, if the `--check` option is provided. It also displays the number of files checked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a header check to the github actions.
As of right now, the headers get checked on every push. We could change that to every pull-request if required.
See individual commits for more information.