Clients: Download client does not filter out tape sources Fix #5122 #5124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeldierkes
force-pushed
the
patch-5122-Download_client_does_not_filter_out_tape_sources
branch
3 times, most recently
from
9aa0bce
to
206693d
Compare
The download client should not download files from a tape RSE if the user is not privileged. The code to check that had a bug introduced in rucio#4196, so the user could read from tape RSEs without restriction. This commit fixes the issue.
joeldierkes
force-pushed
the
patch-5122-Download_client_does_not_filter_out_tape_sources
branch
from
206693d
to
3fa7f8d
Compare
|
LGTM @joeldierkes |
maany
approved these changes
Jan 7, 2022
joeldierkes
deleted the
patch-5122-Download_client_does_not_filter_out_tape_sources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The download client should not download files from a tape RSE if the user is not
privileged.
The code to check that had a bug introduced in #4196, so the user could read
from tape RSEs without restriction. This commit fixes the issue.