Transfers: rework heartbeat handling. Closes #5252 #5306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcarpa
force-pushed
the
patch-5252-conveyor_heartbeat_handling
branch
from
19f2eba
to
9aa6acc
Compare
bari12
reviewed
Mar 9, 2022
Right now heartbeats are updated in the database at each iteration (each activity for multi-activity daemons). This forces us to use a big "older_than" value to avoid the race condition when a big bulk size and slow access to transfertool makes hearbeats expire. At the same time, this puts strain on database with un-needed heartbeat updates when the daemons are lightly loaded. Rework this behavior to perform hearbeat_handler.live() more frequently (each submission, for example), but modify live() to only perform a database update if enough time has passed from last update.
rcarpa
force-pushed
the
patch-5252-conveyor_heartbeat_handling
branch
from
9aa6acc
to
ded5e90
Compare
bari12
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now heartbeats are updated in the database at each iteration
(each activity for multi-activity daemons). This forces us to use
a big "older_than" value to avoid the race condition when a big bulk
size and slow access to transfertool makes hearbeats expire.
At the same time, this puts strain on database with un-needed heartbeat
updates when the daemons are lightly loaded.
Rework this behavior to perform hearbeat_handler.live() more frequently
(each submission, for example), but modify live() to only perform a
database update if enough time has passed from last update.