Core & Internals: allow external cache for auth tokens. Closes #5297 #5309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcarpa
force-pushed
the
patch-5297-memcached_for_auth_tokens
branch
from
5cf1454
to
c35ac00
Compare
…5297 Allow setting auth tokens in memcached, but make it configurable and default this behavior to disabled. Also reduce the duration of token, for rucio#5303
rcarpa
force-pushed
the
patch-5297-memcached_for_auth_tokens
branch
from
c35ac00
to
c9791eb
Compare
Please approve it then as well 😄 |
bari12
approved these changes
Mar 7, 2022
bari12
reviewed
Mar 7, 2022
| 'dogpile.cache.memory', | ||
| expiration_time=3600 | ||
| ) | ||
| if config_get_bool('cache', 'use_external_cache_for_auth_tokens', default=False): |
There was a problem hiding this comment.
Just one comment, please add this also to the documentation
http://rucio.cern.ch/documentation/configuration_parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting auth tokens in memcached, but make it configurable and
default this behavior to disabled.
Also reduce the duration of token, for #5303