Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: handle preflight requests #5843 #5844

Merged
merged 1 commit into from
Aug 29, 2022
Merged

testing: handle preflight requests #5843 #5844

merged 1 commit into from
Aug 29, 2022
+39 −1

Conversation

maany
Copy link
Member

@maany maany commented Aug 29, 2022

Fix #5843

@maany maany requested a review from bari12 August 29, 2022 07:22
@maany maany requested a review from bziemons as a code owner August 29, 2022 07:22
@bari12 bari12 requested a review from mlassnig August 29, 2022 09:26
mlassnig
mlassnig approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@mlassnig mlassnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bari12
bari12 reviewed Aug 29, 2022
View reviewed changes
Copy link
Member

@bari12 bari12 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, leaving this open for some hours for a few more 👀

lib/rucio/web/rest/flaskapi/v1/common.py Show resolved Hide resolved
@bari12 bari12 merged commit f4f8f39 into rucio:master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bari12 bari12 bari12 left review comments

@mlassnig mlassnig mlassnig approved these changes

@bziemons bziemons Awaiting requested review from bziemons

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow CORS headers for preflight requests
3 participants
@maany @mlassnig @bari12