Tests: Resolve flaky Automatix test #5866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 7093082 (Improvements of automatix daemon : Closes rucio#5616, rucio#5617 (rucio#5621), 2022-09-02), the `test_automatix` test fails infrequently. The error message provided suggests, that the `project` variable sometimes get converted to an integer: ``` =================================== FAILURES =================================== ________________________________ test_automatix ________________________________ [gw1] linux -- Python 3.6.8 /usr/bin/python /usr/local/lib64/python3.6/site-packages/sqlalchemy/engine/base.py:1803: in _execute_context cursor, statement, parameters, context /usr/local/lib64/python3.6/site-packages/sqlalchemy/engine/default.py:732: in do_execute cursor.execute(statement, parameters) E psycopg2.errors.UndefinedFunction: operator does not exist: character varying = integer E LINE 3: WHERE dev.dids.project = 17420750 AND dev.dids.did_type = 'C... E ^ E HINT: No operator matches the given name and argument types. You might need to add explicit type casts. ``` The `project` variable used is initialized via the first 8 characters of a random uuid4 string. This string contains hexadecimal values, which can lead to a string with the 8 first characters being just integers. The probability for that with `(10 / 16) ^ 8 = 2.33%` (if we asume a uniform distribution) is fairly low, however, we run the tests quite frequently. This thus is a vaiable candidate for the error. The `filter_engine` used in `list_dids` is responsible for converting the string to an int. This is desired for now. Postgres is the only engine which does not provide a functionality to compare a string and an integer. Using a string which does not automatically gets converted to an integer solves the problem.
joeldierkes
force-pushed
the
feature-5865-implicit-casting-in-automatix-test
branch
from
2b4054b
to
1a3fc55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 7093082 (Improvements of automatix daemon : Closes #5616, #5617
(#5621), 2022-09-02), the
test_automatixtest fails infrequently. Theerror message provided suggests, that the
projectvariable sometimesget converted to an integer:
The
projectvariable used is initialized via the first 8 characters ofa random uuid4 string. This string contains hexadecimal values, which
can lead to a string with the 8 first characters being just integers.
The probability for that with
(10 / 16) ^ 8 = 2.33%(if we asume auniform distribution) is fairly low, however, we run the tests quite
frequently. This thus is a vaiable candidate for the error.
The
filter_engineused inlist_didsis responsible for convertingthe string to an int. This is desired for now. Postgres is the only
engine which does not provide a functionality to compare a string and an
integer.
Using a string which does not automatically gets converted to an integer
solves the problem.