Testing: Add DUNE VO tests #6383 #6563
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm working on #6667 . Once merged, James can rebase this PR and adapt the DUNE VOTests to use the framework. |
|
@maany is there an update on this? |
|
@bari12 this fell off the radar. I can get something working for @jamesp-epcc by Monday |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt at adding some VO tests for DUNE. It tests all of the DUNE-specific functionality in our policy package and performs a complete replication workflow from deterministic to non-deterministic storage. Because we need an environment with multiple containers so that we can include a fake MetaCat server, this is modeled more on the integration tests than on the other VO tests.
I am open to suggestions on how to integrate this better with the other VO tests. For now I have added a separate
dune-testsjob to the top level workflow, because creating a full docker-compose environment doesn't fit well with the existing ATLAS and BelleII tests that just use a single container. However there might be a better way, especially if other VOs want to do something similar to DUNE in the future.These tests rely on the MetaCat container, which is on my Docker account, and the DUNE policy package, which is on my GitHub account. But it might be possible to move these to more official homes, such as the official DUNE GitHub account, if you would prefer not to have the tests rely on code from personal accounts.