Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BDD and isolated component development #2

Closed
maany opened this issue Mar 9, 2022 · 1 comment · Fixed by #16
Closed

BDD and isolated component development #2

maany opened this issue Mar 9, 2022 · 1 comment · Fixed by #16
Assignees
@nimishbongale
Labels
DevOps Building, Testing/CI and Releasing of Rucio UI documentation Improvements or additions to documentation Testing Unit Tests, Integration Tests
Milestone
1.0.0

Comments

@maany
Copy link
Member

maany commented Mar 9, 2022

Motivation

BDD and component testing can be done very well with Storybook

Modification

Install, configure and potentially host on GH pages
@maany maany added documentation Improvements or additions to documentation DevOps Building, Testing/CI and Releasing of Rucio UI Testing Unit Tests, Integration Tests labels Mar 9, 2022
@maany maany added this to the 1.0.0 milestone May 25, 2022
@nimishbongale
Copy link
Member

Potential consideration points:

  1. Repository structure => 3 npm packages, one for the ui library, one for the react application using the ui library, one for the storybook showcasing the UI library
  2. Use of chromatic instead of GH pages (recommended by the storybook team)
  3. Use of CDD in hand with BDD

@maany maany linked a pull request Jun 8, 2022 that will close this issue
Initial Setup of Storybook, React App, CICD deploy to GitHub pages #16
Merged
@maany maany closed this as completed in #16 Jun 10, 2022
maany added a commit to maany/webui that referenced this issue Mar 2, 2023
@maany
add auth-wrapper rucio#2
b7d52f7
maany added a commit to maany/webui that referenced this issue Jul 18, 2023
@maany
feature: fix get subscription tests rucio#2
c9d6650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nimishbongale nimishbongale

Labels
DevOps Building, Testing/CI and Releasing of Rucio UI documentation Improvements or additions to documentation Testing Unit Tests, Integration Tests
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Initial Setup of Storybook, React App, CICD deploy to GitHub pages
2 participants
@maany @nimishbongale