Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard navigation, accessibility, miscellaneous fixes #65

Merged

Conversation

nimishbongale
Copy link
Member

@nimishbongale nimishbongale commented Aug 27, 2022

Fixes #62

  • Adds tabbing between input fields
  • Fixes some accessibility issues
  • Triggers form submit on enter keypress
  • Replaces some occurrences of 'any' with 'unknown'

@maany
Copy link
Member

maany commented Aug 31, 2022

@nimishbongale can you resolve the merge conflict, thanks :)

src/components/Login.tsx Outdated Show resolved Hide resolved
src/stories/Page/Page.tsx Outdated Show resolved Hide resolved
@nimishbongale nimishbongale force-pushed the feature-62-keyboard-navigation-accessibility branch from 74c6562 to 9ed1a45 Compare September 10, 2022 17:51
@maany maany merged commit b243043 into rucio:master Sep 15, 2022
@nimishbongale nimishbongale deleted the feature-62-keyboard-navigation-accessibility branch September 17, 2022 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Keyboard Navigation/Survey for accessibility
2 participants