Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow roxml 4.0.0 #410

Merged
merged 1 commit into from
Dec 12, 2017
Merged

Allow roxml 4.0.0 #410

merged 1 commit into from
Dec 12, 2017

Conversation

pusewicz
Copy link
Contributor

@pusewicz pusewicz commented Dec 11, 2017

@ruckus Updates dependencies so that roxml 4.0 can be used, fixing warnings in new Ruby versions.

roxml-3.3.1/lib/roxml/definition.rb:156: warning: constant ::Fixnum is deprecated

Ref #386

@ruckus ruckus merged commit a84f433 into ruckus:master Dec 12, 2017
@ruckus
Copy link
Owner

ruckus commented Dec 12, 2017

Thank you!

@pusewicz pusewicz deleted the bump-roxml branch December 13, 2017 09:32
@evanlouden
Copy link

Awesome! Any chance you could cut a release? @ruckus

@ruckus
Copy link
Owner

ruckus commented Jan 24, 2018

@evanlouden good idea. Current version is 0.5.1 - I'm not up on semver, would this suggest a 0.6.0 release, or a 0.5.2 one?

@evanlouden
Copy link

evanlouden commented Jan 24, 2018

@ruckus I'm pretty new to development but my guess is it would be a MINOR verision 0.6.0 because it adds functionality in a backwards-compatible manner but isn't a bug fix (PATCH 0.5.2).

Thanks!

@ruckus
Copy link
Owner

ruckus commented Jan 25, 2018

0.6.0 pushed to RubyGems!

ruckus pushed a commit that referenced this pull request Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants