Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mysql 5.7 json support #172

Merged
merged 1 commit into from Jul 27, 2020
Merged

Conversation

bboure
Copy link
Contributor

@bboure bboure commented Oct 26, 2016

Add json support for mysql 5.7.

https://dev.mysql.com/doc/refman/5.7/en/json.html

@codecov-io
Copy link

codecov-io commented Oct 26, 2016

Current coverage is 63.63% (diff: 100%)

Merging #172 into master will increase coverage by 2.55%

@@             master       #172   diff @@
==========================================
  Files            25         25          
  Lines          2960       2772   -188   
  Methods         323        323          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits           1808       1764    -44   
+ Misses         1152       1008   -144   
  Partials          0          0          

Powered by Codecov. Last update d8bfc6b...841bf81

@kevcam4891
Copy link
Contributor

Wow. I had no idea MySQL supported the JSON type, and I've been using it
everyday for 8 years! :D

Benoit Boure mailto:notifications@github.com
October 26, 2016 at 9:40 AM

Add json support for mysql 5.7.

https://dev.mysql.com/doc/refman/5.7/en/json.html


    You can view, comment on, or merge this pull request online at:

#172

    Commit Summary


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#172, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AEb3dncgsDtjPzSkx1zUJl8ScFizIFl4ks5q31g4gaJpZM4KhLor.

@bboure
Copy link
Contributor Author

bboure commented Jul 27, 2020

This PR has been open for almost 4 years now without merging. I guess I'll close it

@bboure bboure closed this Jul 27, 2020
@ruckus
Copy link
Owner

ruckus commented Jul 27, 2020

Hi @bboure thanks for reaching out. I have not touched this project in many years and have essentially abandoned it. I don't have a PHP stack locally I could setup to test this PR. But a quick glance shows that it should work :)

If you want we can re-open and I'll accept the PR.

@bboure
Copy link
Contributor Author

bboure commented Jul 27, 2020

Thanks @ruckus for getting back. I have not used this project for a long time either, but we have been using a fork at Vreasy for years that included this change. It has been working great ever since.

I'll reopen it if you want to merge it

Thanks.

@bboure bboure reopened this Jul 27, 2020
@ruckus ruckus merged commit b0d2db3 into ruckus:master Jul 27, 2020
@ruckus
Copy link
Owner

ruckus commented Jul 27, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants