Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(google-ads): handle unexpected errors during validation #172

Merged
merged 1 commit into from
Dec 6, 2023
Merged

fix(google-ads): handle unexpected errors during validation #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions airbyte-integrations/connectors/source-google-ads/source_google_ads/source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,10 @@ def check_connection(self, logger: logging.Logger, config: Mapping[str, Any]) ->
error_messages = ", ".join([error.message for error in exception.failure.errors])
logger.error(traceback.format_exc())
return False, f"Unable to connect to Google Ads API with the provided configuration - {error_messages}"
except Exception as e:
# fallback for all the unhanded exceptions
logger.error(traceback.format_exc())
return False, f"Unable to connect to Google Ads API with the provided configuration - {repr(e)}"

def streams(self, config: Mapping[str, Any]) -> List[Stream]:
config = self._validate_and_transform(config)
Expand Down
Loading